feat: Modified home page and changed app icon #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-ayush2903
approved these changes
Dec 10, 2019
s-ayush2903
approved these changes
Dec 10, 2019
|
@Priyanka-Sachan I don't see any code change that can bring the UI changes that you have attached. |
atm1504
reviewed
Dec 10, 2019
| android:scaleType="centerCrop" | ||
| android:src="@drawable/back" /> | ||
| <ImageView | ||
| android:layout_width="400dp" |
There was a problem hiding this comment.
Remove all hardcoded dimensions. Define the dimensions in the dimens.xml file and use them here.
Priyanka-Sachan
changed the title
Priyanka-Sachan
force-pushed
the
development
branch
from
aea0160
to
185dbe4
Compare
atm1504
approved these changes
Jan 5, 2020
atm1504
added a commit
that referenced
this pull request
Feb 6, 2020
* login page changed * Changing permission of gradlew * feat: Add circle ci * feat: Update circle ci script * feat: fix circle ci script * fix: Modify gitignore files * chore: Update readme Add readme * after movie added and anwesha name added (#21) * feat: Modify Team Members Data (#14) * Modified the Team Member Data * Fixed useless Comments Co-authored-by: Amartya Mondal <[email protected]> * login page updated (#23) * Added Acommodation Fragment Infrastructure (#25) * Modified home page and changed app icon. (#15) * feat: Updated developers page (#26) * Updated developers page * Fixes #10 * feat: Added Game page (#27) * Updated developers page * Fixes #10 * feat: Add game page * game_page * final * feat: Implement slider (#28) * feat: Fix home screen ui * feat: Implemented slider * feat: Add game (#30) * feat: Add Game * feat: Change nav colour * fix: Fix build * feat: Modify Team and Registration Page (#31) * Modified home page and changed app icon. * Üpdated Team Page and Modified Registration Page * feat: Changes done (#32) * Theme removed, Aftermovie removed, Contact page updated, Homepage icons changed * Updated1 * feat: Fix ui (#33) * feat: Events page (#34) * Added Acommodation Fragment Infrastructure * Minor UI fixes * Minor UI fixes-final final ui * Modified contact page. (#35) * Modified action bar and newsfeed. (#37) * feat: Modify Registration Page and Developer's Page (#36) * Updated Developer's Page, Fixed Registration Page and disabled Call Function of Team Page * Optimize Imports * Updated Anwesha icon and Fixed login orientation (#38) * Special Events page updated (#39) * feat: Remove unwanted dats (#41) * rmv: Remove login * Remove accommdoation * feat: Developers page modified * feat: Regiaster fixed * feat: Update gif * fix: Fix circleci build * feat: Remove register button (#42) * register button removed * fix: Fix Circleci * Update Team Anwesha (#43) * Fixed icon issue (#45) * Changed baseURL * Addedcoming soon in pronite * Fixed build errors * fix: Modify Pronite Page (#46) * Modify Pronite Page * Remove Call Button * new load gif added (#48) * feat: Splash screen added (#44) * Splash screen added * feat: splash screen updated * fix: format corrected * Improved splash screen * Removed unnecessary images * Fixed build issue * Added API and Response file * Updated team page. (#51) * feat: current status of Anwesha added in header view (#50) * fix: header view updated (#52) * fix: header view fixed * fix: header view updated * Add competition page. (#53) * Added live feed Recycler view * Changed NewsFeed to LiveFeed * rmv: Remove game (#56) * feat: Add events category (#57) * feat: Add events category * feat: emove unwanted lines * Fixed navDrawerIssue and Updated Developers Page (#58) * feat: Added tv (#54) * added tv * modified * orientation changes (#59) * Changed order in team page and fix margin issue (#61) * feat: Change pronite (#62) * orientation changes * Pronite changed * fix circleci * feat: Add competetions type data (#60) * feat: Reuse events and competetions * feat: Remove special events * feat: Fix build * feat: Competetion live * feat: Show names properly * feat: Change action bar title . (#64) * Alignment in nav header. * Show correct action bar title. * fix: picture added in developers page (#63) * Change Version Number * fix: Fixed issues related to livefeed and splash screen (#66) * Fixed issues related to livefeed and splash screen * Update LiveFeedApi.java * Added organizer of pronite * Notification (#68) * Open intent * feat: Control Flash Light * Refactor flashilight * feat: Blink Flash light * feat: Check SDK version * feat: Fix updates * feat: Remove test * feat: Events' schedule (#67) * Added Acommodation Fragment Infrastructure * Schedule Updated * Update Sponsor Page (#69) * Fix crash (#71) * feat: Remove handler * fix: Fix crash * feat: Minor fix (#70) * Added Acommodation Fragment Infrastructure * Minor fixes Co-authored-by: debarghya472 <[email protected]> Co-authored-by: Kavya Goyal <[email protected]> Co-authored-by: Ayush Shrivastava <[email protected]> Co-authored-by: Priyanka Sachan <[email protected]> Co-authored-by: Mehulipal <[email protected]> Co-authored-by: somenath sarkar <[email protected]> Co-authored-by: VatsalSin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified home page and changed app icon(issue #8 and#9).