Remove unused/redundant default flows #6731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongliangl
force-pushed
the
20241010-remove-nodeport-default
branch
from
272ae39
to
f94dd91
Compare
``` 1. cookie=0x9030000000000, table=PreRoutingClassifier, priority=200,ip actions=resubmit(,NodePortMark),resubmit(,SessionAffinity),resubmit(,ServiceLB) 2. cookie=0x9030000000000, table=PreRoutingClassifier, priority=200,ipv6 actions=resubmit(,NodePortMark),resubmit(,SessionAffinity),resubmit(,ServiceLB) 3. cookie=0x9000000000000, table=PreRoutingClassifier, priority=0 actions=goto_table:NodePortMark 4. cookie=0x9030000000000, table=NodePortMark, priority=200,ip,nw_dst=192.168.77.100 actions=set_field:0x80000/0x80000->reg4 5. cookie=0x9030000000000, table=NodePortMark, priority=200,ip,nw_dst=169.254.0.252 actions=set_field:0x80000/0x80000->reg4 6. cookie=0x9030000000000, table=NodePortMark, priority=200,ipv6,ipv6_dst=fd00::192:168:77:100 actions=set_field:0x80000/0x80000->reg4 7. cookie=0x9030000000000, table=NodePortMark, priority=200,ipv6,ipv6_dst=fc01::aabb:ccdd:eefe actions=set_field:0x80000/0x80000->reg4 8. cookie=0x9030000000000, table=NodePortMark, priority=0,actions=goto_table:SessionAffinity 9. cookie=0x9030000000000, table=SessionAffinity, priority=0 actions=set_field:0x10000/0x70000->reg4 ``` This commit removes the default flows (flow 3, flow 8) of PreRoutingClassifier and NodePortMark. For flow 3, there is no chance to use it since all packets will be matched by flows 1-2. For flow 8, this is a redundant flow. For example, a packet matched by flow 1 or 2 will be resubmitted to multiple tables, which means the packet will be processed in these tables sequentially. Assuming that a packet with destination 192.168.77.200 is matched by flow 1: 1. NodePortMark: sent by `resubmit(,NodePortMark)`, packet is matched by flow 8 and sent to SessionAffinity. 2. SessionAffinity: packet is matched by flow 9, returns to flow 1 to run the next action `resubmit(,SessionAffinity)`. 3. SessionAffinity: sent by `resubmit(,SessionAffinity)`, packet is matched by flow 9 again, returns to flow 1 to run the next action `resubmit(,ServiceLB)`. 4. ServiceLB: sent by `resubmit(,ServiceLB)`. We can see that the packet is matched by flow 9 twice. By removing flow 8, we can avoid that. Signed-off-by: Hongliang Liu <[email protected]>
hongliangl
force-pushed
the
20241010-remove-nodeport-default
branch
from
f94dd91
to
fc18879
Compare
hongliangl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the default flows (flow 3, flow 8) of PreRoutingClassifier and NodePortMark.
For flow 3, there is no chance to use it since all packets will be matched by flows 1-2.
For flow 8, this is a redundant flow. For example, a packet matched by flow 1 or 2 will
be resubmitted to multiple tables, which means the packet will be processed in these tables
sequentially. Assuming that a packet with destination 192.168.77.200 is matched by flow 1:
resubmit(,NodePortMark), packet is matched by flow 8 and sent toSessionAffinity.
resubmit(,SessionAffinity).resubmit(,SessionAffinity), packet is matched by flow 9 again,returns to flow 1 to run the next action
resubmit(,ServiceLB).resubmit(,ServiceLB).We can see that the packet is matched by flow 9 twice. By removing flow 8, we can avoid that.