feat(host): Add local key value store #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 29, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
clabby
commented
May 29, 2024
Comment on lines
+36
to
+38
| L2_CHAIN_ID_KEY => todo!(), | ||
| L2_CHAIN_CONFIG_KEY => todo!(), | ||
| L2_ROLLUP_CONFIG_KEY => todo!(), |
There was a problem hiding this comment.
We'll need standard definitions of the rollup / chain configuration per-chain. Might actually be time to make those superchain-registry bindings 🫠
There was a problem hiding this comment.
Let's open up a ticket for this so we track and just merge this as is for now to not block
refcell
approved these changes
May 29, 2024
Adds the `LocalKeyValueStore` and the `SplitKeyValueStore`, which routes request for local data to the in-memory configuration.
This was referenced Jun 16, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds the
LocalKeyValueStoreand theSplitKeyValueStore, which routesrequest for local data to the in-memory configuration.