Use timeouts in BackendSession Recv method to fix leaking goroutine #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goroutine leak in issue #62 is caused by
BackendSession.Recv()
being a blocking call, so theprotoReader
goroutine never exits. This PR adds a timeout value toRecv()
so thatprotoReader
has a chance to periodically check if the context is done.The timeout implementation in the websockets backend cannot use
SetReadDeadLine
like the other backends do, because of gorilla/websocket#474. After a timeout error occurs, the websocket connection is no longer usable and must be closed. So instead, we start a goroutine calledrecvChannelizer
which pushes messages to a channel, and exits after any error. The websockets backendRecv()
message then provides "soft" timeouts using a select on this channel or the timeout.