Fix Cloud Report #190
Merged
Fix Cloud Report #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix for ansible#108 don't merge yet... can re-add ability to host in different regions, but this is a much better report
fix for ansible#108 don't merge yet... can re-add ability to host in different regions, but this is a much better report
fix for ansible#108 don't merge yet... can re-add ability to host in different regions, but this is a much better report
|
ready to merge closes out #108 |
jce-redhat
requested changes
Sep 23, 2024
There was a problem hiding this comment.
a lot of the stuff in cloud/setup.yml was moved into the common/ folder, meaning it will get added no matter what demo is configured. this was done in order to support "cross-category" job tasks. if anything in the new project might ever be used in multiple demo categories it should probably be added to common/setup.yml as well.
updating per comment from @jce-redhat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will solve #108