Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CIS control ids #99

Merged
merged 5 commits into from
Apr 23, 2024

Conversation

mfortin
Copy link
Contributor

@mfortin mfortin commented Apr 3, 2024

Overall Review of Changes:
CIS control ids mismatch

Issue Fixes:
Update ID, removed one and fixed order of others

Enhancements:
none

How has this been tested?:
Ansible playbook from a local workstation to an EC2 instance in AWS

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.

Signed-off-by: Mathieu Fortin <[email protected]>
@frederickw082922
Copy link
Contributor

frederickw082922 commented Apr 3, 2024

Thank you for the PR @mfortin ! The playbook failed during the Pipeline run!

TASK [/github/workspace : 18.9.32.6.2 | PATCH | Ensure Allow network connectivity during connected-standby plugged in is set to Disabled] ***
fatal: [AL]: FAILED! => {"msg": "The conditional check 'win19cis_rule_18_3_32_6_2' failed. The error was: error while evaluating conditional (win19cis_rule_18_3_32_6_2): 'win19cis_rule_18_3_32_6_2' is undefined. 'win19cis_rule_18_3_32_6_2' is undefined\n\nThe error appears to be in '/github/workspace/tasks/section18.yml': line 1757, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: "18.9.32.6.2 | PATCH | Ensure Allow network connectivity during connected-standby plugged in is set to Disabled"\n ^ here\n"}

Signed-off-by: Mathieu Fortin <[email protected]>
@mfortin
Copy link
Contributor Author

mfortin commented Apr 3, 2024

@frederickw082922 I fixed the rule condition, there was a typo there too.

Signed-off-by: Mathieu Fortin <[email protected]>
@mfortin
Copy link
Contributor Author

mfortin commented Apr 5, 2024

There are still 2 updates that did not get ported in #100. One is minor, the other one prevents this role from executing on Amazon EC2 instances due to a race condition related to the ordering of controls in section 01.

Signed-off-by: Mathieu Fortin <[email protected]>
Copy link
Contributor

@frederickw082922 frederickw082922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @mfortin ! Thank you!

@frederickw082922 frederickw082922 merged commit 063021e into ansible-lockdown:devel Apr 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants