-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CIS control ids #99
Fix CIS control ids #99
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.
Signed-off-by: Mathieu Fortin <[email protected]>
Thank you for the PR @mfortin ! The playbook failed during the Pipeline run! TASK [/github/workspace : 18.9.32.6.2 | PATCH | Ensure Allow network connectivity during connected-standby plugged in is set to Disabled] *** |
Signed-off-by: Mathieu Fortin <[email protected]>
@frederickw082922 I fixed the rule condition, there was a typo there too. |
Signed-off-by: Mathieu Fortin <[email protected]>
Signed-off-by: Math Fortin <[email protected]>
There are still 2 updates that did not get ported in #100. One is minor, the other one prevents this role from executing on Amazon EC2 instances due to a race condition related to the ordering of controls in section 01. |
Signed-off-by: Mathieu Fortin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @mfortin ! Thank you!
Overall Review of Changes:
CIS control ids mismatch
Issue Fixes:
Update ID, removed one and fixed order of others
Enhancements:
none
How has this been tested?:
Ansible playbook from a local workstation to an EC2 instance in AWS