-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
24 changed files
with
28,511 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
# Community package requirements: sanity tests | ||
|
||
(Note: This issue was filed in a semi-automated fashion. Let me know if you see errors in this issue.) | ||
|
||
As per the [Ansible community package inclusion requirements][ci-testing], collections must pass `ansible-test sanity` tests. Version `1.5.4` of `ansible.posix`, corresponding to the `1.5.4` tag in this repo, fails one or more of the required sanity tests. | ||
|
||
|
||
Please see the errors below and address them. If these issues aren't addressed within a reasonable time period, the collection may be subject to [removal from Ansible][removal]. | ||
|
||
Thank you for your efforts and for being part of the Ansible package! We appreciate it. | ||
|
||
--- | ||
|
||
## Sanity tests | ||
|
||
The following tests were run using `ansible-test` version `2.17.3`: | ||
|
||
- ansible-doc | ||
- compile | ||
- validate-modules | ||
- yamllint | ||
|
||
Note that this is only a subset of the required sanity tests. Please make sure you run them in all in your CI. | ||
|
||
### Results | ||
|
||
> **💡 NOTE:** | ||
> | ||
> Check the `[explain]` links below for more information about each test and how to fix failures. | ||
> See [Sanity Tests: Ignores](https://docs.ansible.com/ansible/latest/dev_guide/testing/sanity/ignores.html) in the dev guide if, after reading the test-specific documentation, you still believe an error is a false positive. | ||
The test `ansible-test sanity --test validate-modules` [[explain](https://docs.ansible.com/ansible-core/2.17/dev_guide/testing/sanity/validate-modules.html)] failed with 9 errors: | ||
|
||
``` text | ||
plugins/modules/synchronize.py:0:0: doc-default-does-not-match-spec: Argument '_local_rsync_path' in argument_spec defines default as ('rsync') but documentation defines default as (None) | ||
plugins/modules/synchronize.py:0:0: doc-default-does-not-match-spec: Argument '_substitute_controller' in argument_spec defines default as (False) but documentation defines default as (None) | ||
plugins/modules/synchronize.py:0:0: doc-default-does-not-match-spec: Argument 'rsync_opts' in argument_spec defines default as ([]) but documentation defines default as (None) | ||
plugins/modules/synchronize.py:0:0: nonexistent-parameter-documented: Argument 'use_ssh_args' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec | ||
plugins/modules/synchronize.py:0:0: parameter-type-not-in-doc: Argument 'ssh_args' in argument_spec defines type as 'str' but documentation doesn't define type | ||
plugins/modules/synchronize.py:0:0: undocumented-parameter: Argument '_local_rsync_password' is listed in the argument_spec, but not documented in the module documentation | ||
plugins/modules/synchronize.py:0:0: undocumented-parameter: Argument '_local_rsync_path' is listed in the argument_spec, but not documented in the module documentation | ||
plugins/modules/synchronize.py:0:0: undocumented-parameter: Argument '_substitute_controller' is listed in the argument_spec, but not documented in the module documentation | ||
plugins/modules/synchronize.py:0:0: undocumented-parameter: Argument 'ssh_args' is listed in the argument_spec, but not documented in the module documentation | ||
``` | ||
|
||
|
||
|
||
|
||
[ci-testing]: https://docs.ansible.com/ansible/latest/community/collection_contributors/collection_requirements.html#ci-testing | ||
[repo-mgmt]: https://docs.ansible.com/ansible/latest/community/collection_contributors/collection_requirements.html#repository-management | ||
[removal]: https://github.com/ansible-collections/overview/blob/main/removal_from_ansible.rst |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
# Community package requirements: sanity tests and repository management | ||
|
||
(Note: This issue was filed in a semi-automated fashion. Let me know if you see errors in this issue.) | ||
|
||
As per the [Ansible community package inclusion requirements][ci-testing], collections must pass `ansible-test sanity` tests. Version `24.6.1` of `awx.awx`, corresponding to the `24.6.1` tag in this repo, fails one or more of the required sanity tests. | ||
|
||
The contents in the `24.6.1` git tag do not match `awx-awx-24.6.1.tar.gz` as uploaded to Ansible Galaxy. For future releases, please make sure that the contents uploaded to Galaxy match the sources that were tagged as that release. See the [Repository management requirements][repo-mgmt] for more information. | ||
|
||
Please see the errors below and address them. If these issues aren't addressed within a reasonable time period, the collection may be subject to [removal from Ansible][removal]. | ||
|
||
Thank you for your efforts and for being part of the Ansible package! We appreciate it. | ||
|
||
--- | ||
|
||
## Sanity tests | ||
|
||
The following tests were run using `ansible-test` version `2.17.3`: | ||
|
||
- ansible-doc | ||
- compile | ||
- validate-modules | ||
- yamllint | ||
|
||
Note that this is only a subset of the required sanity tests. Please make sure you run them in all in your CI. | ||
|
||
### Results | ||
|
||
`ansible-test sanity` succeeded, but some required tests were ignored. | ||
|
||
### Invalid test ignores | ||
|
||
`tests/sanity/ignore-2.17.txt` contain ignores that are forbidden by the [CI testing requirements][ci-testing]: | ||
|
||
``` text | ||
plugins/modules/export.py validate-modules:nonexistent-parameter-documented # needs awxkit to construct argspec | ||
``` | ||
|
||
Please fix these issues and remove the ignore entries. | ||
|
||
## File divergences | ||
|
||
The following files differ between the `24.6.1` git tag and `awx-awx-24.6.1.tar.gz` on Ansible Galaxy: | ||
|
||
- `plugins/module_utils/controller_api.py` (`WRONG_HASH`) | ||
|
||
|
||
[ci-testing]: https://docs.ansible.com/ansible/latest/community/collection_contributors/collection_requirements.html#ci-testing | ||
[repo-mgmt]: https://docs.ansible.com/ansible/latest/community/collection_contributors/collection_requirements.html#repository-management | ||
[removal]: https://github.com/ansible-collections/overview/blob/main/removal_from_ansible.rst |
Oops, something went wrong.