Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate antsibull-docutils into CI and build scripts and instructions #309

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

felixfontein
Copy link
Collaborator

README.md Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
noxfile.py Show resolved Hide resolved
@gotmax23 gotmax23 marked this pull request as draft August 21, 2024 15:39
@felixfontein felixfontein marked this pull request as ready for review August 21, 2024 17:17
@felixfontein
Copy link
Collaborator Author

I've marked this back to ready for review since it's needed for ansible-community/antsibull-changelog#174.

@gotmax23
Copy link
Collaborator

I'll try to get to this later today.

Copy link
Collaborator

@gotmax23 gotmax23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! If the plan is for antsibull-docs to directly utilize code for antsibull-docutils, we should also add a direct dependency on it.

@felixfontein
Copy link
Collaborator Author

I agree. Right now it only uses it indirectly, but if we want to add MarkDown output to antsibull-docs at some point, it will be useful (and then it definitely should become a direct dependency). Or if antsibull-docutils has a RST writer, then we could allow collections to have extra docs in MarkDown.

@felixfontein felixfontein merged commit 2e3ee0c into ansible-community:main Aug 22, 2024
12 checks passed
@felixfontein felixfontein deleted the docutils branch August 22, 2024 18:33
@felixfontein
Copy link
Collaborator Author

@gotmax23 thanks for this one as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants