Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galaxy: determine latest version: allow to specify constraints #99

Closed

Conversation

felixfontein
Copy link
Collaborator

No description provided.

@@ -356,6 +361,8 @@ async def get_latest_matching_version(
spec = semver.SimpleSpec(version_spec)
prereleases = []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixfontein not really related to the PR but I saw this block of code and wanted to mention that I've implemented the "allow pre-release if no stables on galaxy" that's coming in core 2.16 (and likely 2.15 too): ansible/ansible@7662a05#diff-fe795e4ef8c29c07418d68d6a5c81d0d1779205a01b5b41a2f708d5184e15e2aR299. In case this'd be useful for antsibull...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It won't be useful for antsibull though (or at least not anytime soon) since it doesn't use ansible-core's galaxy code or collection version resolving code at all.

@felixfontein
Copy link
Collaborator Author

I've changed ansible-community/antsibull-build#546 to no longer depend on GalaxyClient.get_latest_matching_version(). So likely this PR isn't needed anymore.

@felixfontein felixfontein deleted the constraints branch September 27, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants