Pydantic: add helper, generalize forbid extra code #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, Pydantic does funky stuff with Python 3.9 and 3.10: >>> issubclass(dict, p.BaseModel)
False
>>> issubclass(int, p.BaseModel)
False
>>> issubclass(dict[int, int], p.BaseModel)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python3.9/abc.py", line 123, in __subclasscheck__
return _abc_subclasscheck(cls, subclass)
TypeError: issubclass() arg 1 must be a class(Not that I'm surprised it does funky stuff...) |
gotmax23
reviewed
Sep 15, 2024
| _modify_config(models, processed_classes, change_config) | ||
|
|
||
|
|
||
| def forbid_extras(models: type[p.BaseModel] | Collection[type[p.BaseModel]]) -> None: |
There was a problem hiding this comment.
Looking at this, I feel there has to be a better way. Maybe file an RFE with pydantic asking for a way to validate a model with extra="forbid" without having to change the model's configuration? Maybe an extra kwarg in the model_validate() method to configure this? In the meantime, I think this is workable, just not super pretty.
There was a problem hiding this comment.
There's already pydantic/pydantic#2652, to which I added a comment.
felixfontein
added a commit
to felixfontein/antsibull-docs
that referenced
this pull request
Sep 15, 2024
5 tasks
felixfontein
added a commit
to felixfontein/antsibull-docs
that referenced
this pull request
Sep 15, 2024
felixfontein
added a commit
to felixfontein/antsibull-docs
that referenced
this pull request
Sep 15, 2024
felixfontein
added a commit
to felixfontein/antsibull-docs
that referenced
this pull request
Sep 15, 2024
gotmax23
approved these changes
Sep 16, 2024
|
@gotmax23 thanks for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.