Collection removal metadata: remove bad check (#172)

* Remove bad check.

* Ignore new linting rule.

.pylintrc.automated

@@ -77,6 +77,7 @@ disable=
     too-many-locals,
     too-many-return-statements,
     too-many-statements,
+    too-many-positional-arguments,
 
 # Enable the message, report, category or checker with the given id(s). You can
 # either give multiple identifier separated by comma (,) or put this option

changelogs/fragments/172-removal-schema.yml

@@ -0,0 +1,2 @@
+bugfixes:
+  - "Collection metadata removal schema valiation: remove bad check that deprecated redirect replacement major version must be in the future (https://github.com/ansible-community/antsibull-core/pull/172)."

src/antsibull_core/collection_meta.py

@@ -63,24 +63,6 @@ def _validate_removal(
                 f" must not be larger than the current major version {self.major_release}"
             )
 
-        if removal.redirect_replacement_major_version is not None:
-            if removal.redirect_replacement_major_version <= self.major_release:
-                self.errors.append(
-                    f"{prefix} redirect_replacement_major_version: Redirect removal version"
-                    f" {removal.redirect_replacement_major_version} must be larger than"
-                    f" current major version {self.major_release}"
-                )
-            if (
-                removal.major_version != "TBD"
-                and removal.redirect_replacement_major_version  # pyre-ignore[58]
-                >= removal.major_version
-            ):
-                self.errors.append(
-                    f"{prefix} redirect_replacement_major_version: Redirect removal major version"
-                    f" {removal.redirect_replacement_major_version} must be smaller than"
-                    f" the removal major version {removal.major_version}"
-                )
-
         if removal.reason == "renamed" and removal.new_name == collection:
             self.errors.append(f"{prefix} new_name: Must not be the collection's name")
 

tests/functional/test_collection_meta.py

@@ -157,7 +157,6 @@
             "collections -> bad.bar1 -> removal -> major_version: Removal major version 7 must be larger than current major version 9",
             "collections -> bad.bar1: Collection not in ansible.in",
             "collections -> bad.bar2 -> removal -> new_name: Must not be the collection's name",
-            "collections -> bad.bar2 -> removal -> redirect_replacement_major_version: Redirect removal version 9 must be larger than current major version 9",
             "collections -> bad.bar2: Collection not in ansible.in",
             "collections -> baz.bam -> repository: Required field not provided",
             "collections -> baz.bam: Collection not in ansible.in",