Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Cancel deprecation of netapp.storagegrid #488

Closed

Conversation

felixfontein
Copy link
Contributor

Depends on https://forum.ansible.com/t/2811/24

Needs ansible-community/antsibull-core#177 and ansible-community/antsibull-build#640 and ansible-community/antsibull-docs#352.

This will not modify the existing changelogs, and add the following entries:

  • 9.12.0:
    major_changes:
      - The removal of netapp.storagegrid was cancelled. The collection will not be removed from Ansible 11.
  • 10.6.0:
    major_changes:
      - The removal of netapp.storagegrid was cancelled. The collection will not be removed from Ansible 11.
  • 11.0.0b1:
    major_changes:
      - The previously removed collection netapp.storagegrid was re-added to Ansible 11.

@felixfontein
Copy link
Contributor Author

I'd like to improve the new changelog entries (like including the link to the discussion), but let's do that in the future and not for now. The timeline's already way too tight for all the releases on Tuesday.

@mariolenz
Copy link
Collaborator

I agree we it might be hard to implement this properly because there's not enough time. But how should we cancel the deprecation / re-add netapp.storagegrid if https://forum.ansible.com/t/2811/24 is accepted?

Would #489 would be OK?

@felixfontein
Copy link
Contributor Author

#489 is kind of the minimal version to re-add it; this PR is a better version (but requires tooling support from antsibull-core and antsibull-build, and also antsibull-docs so that Ansible 9 and 10 stop saying it will be removed from Ansible 11).

@mariolenz
Copy link
Collaborator

this PR is a better version (but requires tooling support from antsibull-core and antsibull-build, and also antsibull-docs

Yes, that's the problem. If we agree to re-add / cancel the deprecation, do we get this support in time for tomorrow? Or should we do it quick'n'dirty like in #489?

If we get this support in time, I'm fine with closing my PR and use this one :-)

@felixfontein
Copy link
Contributor Author

If I get the PRs reviewed until I get up tomorrow morning and only small changes (or none) are required, we can get support for this by then. If not, then not. In that case we should merge your PR; we can still improve the situation later with this PR in a rebased form. But first of all we need a vote for not removing the collection; so far with 3 SC votes it doesn't look so good :(

@felixfontein
Copy link
Contributor Author

(I'll do an antsibull-build release tomorrow morning no matter whether the new PRs get merged or not, to get the changelog editing feature out.)

@felixfontein
Copy link
Contributor Author

Closing since the removal was not cancelled. See https://forum.ansible.com/t/2811/28 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants