Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vmware.vmware to Ansible 9+ #439

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

mariolenz
Copy link
Collaborator

@mariolenz mariolenz marked this pull request as draft June 30, 2024 13:21
@felixfontein
Copy link
Contributor

Out of curiosity: why not add it to Ansible 9 as well?

@mariolenz
Copy link
Collaborator Author

Maybe I got this wrong, but I thought Ansible 9 is kind of an LTS release where we don't add new collections. We didn't add ieisystem.inmanage there, either: #431

And your PR to add kubevirt.core is also about 10 and 11, not 9: #419

I think vmware.vmware should work in Ansible 9 because they claim to work with ansible-core >= 2.15.0. But if we add it to 9, we should also talk about adding ieisystem.inmanage and kubevirt.core, too.

I'm not against adding this collection to the Ansible Community Package 9, I just thought we don't want to do this 🤷

Correct me I've I'm wrong. But, as I've said, we also should have another look at ieisystem.inmanage and kubevirt.core.

@felixfontein
Copy link
Contributor

It's not really LTS, since it accepts new features in collections. So why not also add new collections?

For ieisystem.inmanage that was likely an oversight, and we should fix that.

For kubevirt.core that was intentional, since it depends on kubernetes.core >= 3.1.0, while Ansible 9 contains kubernetes.core 2.x.y. So it's not possible to add it to Ansible 9. (See also https://forum.ansible.com/t/5084/8 :) )

@mariolenz mariolenz changed the title Add vmware.vmware to Ansible 10 and 11 Add vmware.vmware to Ansible 9+ Jul 1, 2024
@mariolenz mariolenz marked this pull request as ready for review July 1, 2024 15:25
@mariolenz mariolenz marked this pull request as draft July 1, 2024 15:30
@mariolenz mariolenz marked this pull request as ready for review July 2, 2024 14:53
@mariolenz
Copy link
Collaborator Author

@felixfontein @samccann Thanks for reviewing!

@mariolenz mariolenz merged commit d624b65 into ansible-community:main Jul 2, 2024
5 checks passed
@mariolenz mariolenz deleted the add_vmware.vmware branch July 2, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants