Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow handling of vlan ID values containing more then one digit. #460

Merged

Conversation

kerry-meyer
Copy link
Collaborator

@kerry-meyer kerry-meyer commented Oct 4, 2024

SUMMARY

A utility function used in this resource module for converting incoming vlan IDs and vlan ranges for use in REST APIs used an incorrect criterion for distinguishing an individual vlan ID from a vlan range. It assumed that the length of the incoming "vlan_id" string would be 1 for an individual vlan and longer for a range. As a result, it failed to correctly recognize an individual vlan ID with more than one digit. Because the "problem" cases were all handled by this shared function, a simple fix in this utility function is sufficient for fixing the problem in the cases where it would have occurred.

GitHub Issues

List the GitHub issues impacted by this PR. If no Github issues are affected, please indicate this with "N/A".

GitHub Issue #
N/A
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

sonic_stp

OUTPUT

STP regression test summary:

STP_multi_digit_vlan_regression_2024_1004.pdf

Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document
How Has This Been Tested?
  • playbooks using each of the allowed forms of vlans in a list
  • regression test execution

@kerry-meyer kerry-meyer merged commit 26157a2 into ansible-collections:main Oct 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants