Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new unreliable_los option #453

Merged
merged 15 commits into from
Sep 26, 2024

Conversation

aida-shumburo
Copy link
Collaborator

@aida-shumburo aida-shumburo commented Sep 20, 2024

SUMMARY

Set interface configuration option for when to generate a 'loss of service' (LOS) alarm

GitHub Issues

"N/A"

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

sonic_interfaces

OUTPUT
Ansible Report:

add_unreliable_los.pdf

Raw Regression Test Output:

unreliable_los.zip

Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document
How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • I ran different ansible playbooks to test that the new ' unreliable_los' option value is being merged, replaced, deleted, and overriden the correct way
  • Ran a regression test (attached above)

@aida-shumburo aida-shumburo marked this pull request as ready for review September 24, 2024 17:54
Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for providing this new functionality.

I am posting a few minor comments to address before merging of this PR.

plugins/modules/sonic_interfaces.py Show resolved Hide resolved
plugins/modules/sonic_interfaces.py Outdated Show resolved Hide resolved
tests/regression/roles/sonic_interfaces/defaults/main.yml Outdated Show resolved Hide resolved
tests/regression/roles/sonic_interfaces/defaults/main.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost all of the pending "Issues" are "Resolved" by your most recent set of changes.

I have one remaining "Issue" related to setting up the required conditions for integration test_06.

Everything else looks good.

Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the final requested change.

All proposed code changes, added test cases, and test results look good.

Approved.

@kerry-meyer kerry-meyer merged commit 9c46aa7 into ansible-collections:main Sep 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants