Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken module documentation links in the README.md file #446

Merged

Conversation

kerry-meyer
Copy link
Collaborator

@kerry-meyer kerry-meyer commented Sep 6, 2024

SUMMARY

Ansible/Redhat has moved the location for automatically generated module documentation from a location in the "docs.ansible.com" domain to a new location in the "galaxy.ansible.com" domain. This change set modifies the module documentation links used in the README.md file for this resource module collection to use the new location instead of the deprecated old location. These changes are also intended to fix the module documentation links in the embedded, derived content for this resource module collection on the web page at "https://galaxy.ansible.com/ui/repo/published/dellemc/enterprise_sonic/docs/".

GitHub Issues

List the GitHub issues impacted by this PR. If no Github issues are affected, please indicate this with "N/A".

GitHub Issue #
N/A
ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

README

OUTPUT

Result of accessing a module documentation link (for the qos_interfaces module) without the changes:

image

Result of accessing the same module documentation link (for the qos_interfaces module) after the changes:

image

ADDITIONAL INFORMATION

Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document
How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Verify that previously failing links are now working correctly.

@kerry-meyer kerry-meyer changed the title Change obsolete module documentation links in the README.md file to use the new Ansible Galaxy documentation web site. Fix broken module documentation links in the README.md file Sep 6, 2024
@kerry-meyer kerry-meyer added the documentation Improvements or additions to documentation label Sep 6, 2024
@kerry-meyer kerry-meyer merged commit 077e63a into ansible-collections:main Sep 6, 2024
15 checks passed
@kerry-meyer kerry-meyer deleted the README_doc_links_fix branch September 11, 2024 23:00
kerry-meyer added a commit that referenced this pull request Sep 17, 2024
* In the enterprise_sonic README.md file, use the new Galaxy module documentation site for all links.

* Add a changelog fragment for this PR.

* Fix incorrect global regex results.

* Change the fragment designation to "trivial" to match changing the PR type to "documentation".

* Delete changed, redundant fragment file.
@kerry-meyer kerry-meyer mentioned this pull request Sep 17, 2024
9 tasks
kerry-meyer added a commit that referenced this pull request Sep 17, 2024
* Enable system auditd and ip loadshare hash downward compatibility (#441)

* Enable system auditd and ip loadshare hash downward compatibility.

* Add a fragment file.

* Add mock handling for edit_config_catch

* Fix sanity errors.

* Fix mistakes in the fragment file.

* Modify the fix to operation on individual requests in the enterprise_sonic httpapi plugin.

* Enable conditional suppression of GET exceptions.

* Fix handling for an empty GET response.

* Fix an indentation in the PoE facts file and fix global PoE empty configuration handling.

* Update regex expression in edit_config method (#443)

* Update regex expression in edit_config method

* Change fragment to bugfix

* Update 443-update-regex-edit-config.yaml

* Add import of the Ansible ConnectionError exception class for all files where it is used. (#445)

* Add import of the Ansible ConnectionError exception class for all files where it is used.

* Add a fragment file.

* Fix broken module documentation links in the README.md file (#446)

* In the enterprise_sonic README.md file, use the new Galaxy module documentation site for all links.

* Add a changelog fragment for this PR.

* Fix incorrect global regex results.

* Change the fragment designation to "trivial" to match changing the PR type to "documentation".

* Delete changed, redundant fragment file.

---------

Co-authored-by: stalabi1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants