Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab_runner: update requirements in docs #8860

Merged
merged 2 commits into from
Sep 17, 2024
Merged

gitlab_runner: update requirements in docs #8860

merged 2 commits into from
Sep 17, 2024

Conversation

ch-e-mistry
Copy link
Contributor

SUMMARY

Be specific related requirements for package version. This difference change the whole dependency chain for playbook.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

community.general.gitlab_runner module documentation.

ADDITIONAL INFORMATION

Sorry if I left something important for the PR. It is really just a document change / clarification.

@ch-e-mistry
Update gitlab_runner.py
394e3ea 
Be specific related requirements for package version. This difference change the whole dependency chain for playbook.
@ansibullbot
Copy link
Collaborator

cc @Lunik @SamyCoenen @Shaps @lgatellier @marwatk @metanovii @nejch @scodeman @sh0shin @suukit @waheedi @zanssa
click here for bot help

@ansibullbot ansibullbot added docs docs_only module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Sep 13, 2024
@ansibullbot

This comment was marked as resolved.

Sign in to view
@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Sep 13, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-8 Automatically create a backport for the stable-8 branch backport-9 Automatically create a backport for the stable-9 branch labels Sep 13, 2024
felixfontein
felixfontein reviewed Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

plugins/modules/gitlab_runner.py Outdated Show resolved Hide resolved
@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Sep 13, 2024
@russoz russoz changed the title Update gitlab_runner.py gitlab_runner: update docs Sep 13, 2024
@russoz russoz changed the title gitlab_runner: update docs gitlab_runner: update requirements in docs Sep 13, 2024
russoz
russoz approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ch-e-mistry
Copy link
Contributor Author

thank you for the review and suggestion.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Sep 17, 2024
@felixfontein felixfontein merged commit f93883a into ansible-collections:main Sep 17, 2024
147 checks passed
@patchback Patchback
Copy link

patchback bot commented Sep 17, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/f93883aa204ac57e4e39ad09d644d02f17b35096/pr-8860

Backported as #8879

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 17, 2024
@ch-e-mistry @patchback
gitlab_runner: update requirements in docs (#8860)
3f3547c 
* Update gitlab_runner.py

Be specific related requirements for package version. This difference change the whole dependency chain for playbook.

* Update plugins/modules/gitlab_runner.py

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit f93883a)
@patchback patchback bot mentioned this pull request Sep 17, 2024
Merged
@patchback Patchback
Copy link

patchback bot commented Sep 17, 2024 •
edited
Loading

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/f93883aa204ac57e4e39ad09d644d02f17b35096/pr-8860

Backported as #8880

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@ch-e-mistry thanks for your contribution!
@russoz thanks for reviewing!

patchback bot pushed a commit that referenced this pull request Sep 17, 2024
@ch-e-mistry @patchback
gitlab_runner: update requirements in docs (#8860)
1d6a5d7 
* Update gitlab_runner.py

Be specific related requirements for package version. This difference change the whole dependency chain for playbook.

* Update plugins/modules/gitlab_runner.py

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit f93883a)
@patchback patchback bot mentioned this pull request Sep 17, 2024
Merged
felixfontein pushed a commit that referenced this pull request Sep 17, 2024
@patchback @ch-e-mistry
[PR #8860/f93883aa backport][stable-8] gitlab_runner: update requirem…
d122d3f 
…ents in docs (#8879)

gitlab_runner: update requirements in docs (#8860)

* Update gitlab_runner.py

Be specific related requirements for package version. This difference change the whole dependency chain for playbook.

* Update plugins/modules/gitlab_runner.py

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit f93883a)

Co-authored-by: Péter Mikáczó <[email protected]>
felixfontein pushed a commit that referenced this pull request Sep 17, 2024
@patchback @ch-e-mistry
[PR #8860/f93883aa backport][stable-9] gitlab_runner: update requirem…
5550ba1 
…ents in docs (#8880)

gitlab_runner: update requirements in docs (#8860)

* Update gitlab_runner.py

Be specific related requirements for package version. This difference change the whole dependency chain for playbook.

* Update plugins/modules/gitlab_runner.py

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit f93883a)

Co-authored-by: Péter Mikáczó <[email protected]>
@ch-e-mistry ch-e-mistry deleted the patch-1 branch September 22, 2024 15:01
aioue pushed a commit to aioue/community.general that referenced this pull request Oct 1, 2024
@ch-e-mistry @felixfontein @aioue
gitlab_runner: update requirements in docs (ansible-collections#8860)
991b93d 
* Update gitlab_runner.py

Be specific related requirements for package version. This difference change the whole dependency chain for playbook.

* Update plugins/modules/gitlab_runner.py

Co-authored-by: Felix Fontein <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

@russoz russoz russoz approved these changes

Assignees
No one assigned
Labels
backport-8 Automatically create a backport for the stable-8 branch backport-9 Automatically create a backport for the stable-9 branch docs_only docs module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ch-e-mistry @ansibullbot @felixfontein @russoz