Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for new zones for scaleway #8680

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add support for new zones for scaleway #8680

wants to merge 3 commits into from

Conversation

remyleone
Copy link
Contributor

SUMMARY

Add support for new zones for Scaleway modules in ansible

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

scaleway

@ansibullbot
Copy link
Collaborator

cc @abarbare
click here for bot help

@ansibullbot ansibullbot added cloud feature This issue/PR relates to a feature request module_utils module_utils plugins plugin (any type) small_patch Hopefully easy to review labels Jul 26, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-9 Automatically create a backport for the stable-9 branch labels Jul 26, 2024
@felixfontein
Copy link
Collaborator

@remyleone thanks for your contribution! Can you please add a changelog fragment? Thanks.

@ansibullbot ansibullbot removed the small_patch Hopefully easy to review label Jul 26, 2024
@felixfontein
Copy link
Collaborator

Looks formally OK from my side. But I'm curious, the list in SCALEWAY_ZONES is not used anywhere in the code, is it? The code seems to use SCALEWAY_LOCATION.

@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Aug 3, 2024
@felixfontein
Copy link
Collaborator

Ping @remyleone ^

@remyleone
Copy link
Contributor Author

I think it is used in other part of the code but looking with a grep and I got several hits

@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label Sep 18, 2024
@ansibullbot
Copy link
Collaborator

The test ansible-test sanity --test validate-modules [explain] failed with 14 errors:

plugins/modules/scaleway_compute.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_compute_private_network.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_image_info.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_ip.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_ip_info.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_private_network.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_security_group.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_security_group_info.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_security_group_rule.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_server_info.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_snapshot_info.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_user_data.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_volume.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_volume_info.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])

The test ansible-test sanity --test validate-modules [explain] failed with 14 errors:

plugins/modules/scaleway_compute.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_compute_private_network.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_image_info.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_ip.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_ip_info.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_private_network.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_security_group.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_security_group_info.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_security_group_rule.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_server_info.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_snapshot_info.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_user_data.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_volume.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_volume_info.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])

The test ansible-test sanity --test validate-modules [explain] failed with 14 errors:

plugins/modules/scaleway_compute.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_compute_private_network.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_image_info.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_ip.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_ip_info.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_private_network.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_security_group.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_security_group_info.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_security_group_rule.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_server_info.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_snapshot_info.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_user_data.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_volume.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_volume_info.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])

The test ansible-test sanity --test validate-modules [explain] failed with 14 errors:

plugins/modules/scaleway_compute.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_compute_private_network.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_image_info.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_ip.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_ip_info.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_private_network.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_security_group.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_security_group_info.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_security_group_rule.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_server_info.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_snapshot_info.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_user_data.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_volume.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])
plugins/modules/scaleway_volume_info.py:0:0: doc-choices-do-not-match-spec: Argument 'region' in argument_spec defines choices as (['par1', 'EMEA-FR-PAR1', 'fr-par-1', 'par2', 'EMEA-FR-PAR2', 'fr-par-2', 'fr-par-3', 'ams1', 'EMEA-NL-EVS', 'nl-ams-1', 'nl-ams-2', 'nl-ams-3', 'waw1', 'EMEA-PL-WAW1', 'pl-waw-1', 'pl-waw-2', 'pl-waw-3']) but documentation defines choices as (['ams1', 'EMEA-NL-EVS', 'par1', 'EMEA-FR-PAR1', 'par2', 'EMEA-FR-PAR2', 'waw1', 'EMEA-PL-WAW1'])

click here for bot help

@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Sep 18, 2024
@felixfontein
Copy link
Collaborator

Out of curiosity, where did you find any usage of SCALEWAY_ZONES?

@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Sep 26, 2024
@felixfontein felixfontein removed the backport-9 Automatically create a backport for the stable-9 branch label Oct 7, 2024
@felixfontein
Copy link
Collaborator

@remyleone please note that you need to fix the sanity test failures; choices in the documentation needs to be updated as well.

@felixfontein felixfontein added the backport-10 Automatically create a backport for the stable-10 branch label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-10 Automatically create a backport for the stable-10 branch check-before-release PR will be looked at again shortly before release and merged if possible. cloud feature This issue/PR relates to a feature request module_utils module_utils needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remyleone @ansibullbot @felixfontein