Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor x509_certificate module, add x509_certificate_pipe module #135

Merged
merged 33 commits into from
Nov 24, 2020
Merged

Refactor x509_certificate module, add x509_certificate_pipe module #135

Show file tree
Hide file tree
Changes from 31 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
05add45
Move documentation to doc fragment.
felixfontein Nov 1, 2020
ebbaa68
Prepare module backends.
felixfontein Nov 1, 2020
bed3a40
Linting.
felixfontein Nov 1, 2020
42117f5
Fix comments.
felixfontein Nov 2, 2020
97661a1
First shot at actually moving code.
felixfontein Nov 2, 2020
5070849
Forgot SKI check.
felixfontein Nov 2, 2020
94d15a4
Remove unused imports.
felixfontein Nov 2, 2020
30b1dbb
Improve check mode.
felixfontein Nov 2, 2020
6edf8c1
Fix 'returned'.
felixfontein Nov 2, 2020
8dc9c51
Move csr_* checks.
felixfontein Nov 2, 2020
a446607
Explicitly specify parameter.
felixfontein Nov 2, 2020
8980302
Add x509_certificate_pipe module.
felixfontein Nov 2, 2020
47820a0
Update other seealsos.
felixfontein Nov 2, 2020
8496891
Forgot to remove doc fragment.
felixfontein Nov 2, 2020
655b3b8
Adjust to work with macOS 10.15.
felixfontein Nov 3, 2020
82dc5ae
Update plugins/module_utils/crypto/module_backends/certificate_entrus…
felixfontein Nov 10, 2020
d59e4e6
Add changelog fragments for entrust bugfix and module refactorings.
felixfontein Nov 10, 2020
ad84f76
Restore old behavior of Entrust backend when existing certificate can…
felixfontein Nov 10, 2020
44a14a5
Update plugins/modules/x509_certificate_pipe.py
felixfontein Nov 12, 2020
89e1d91
Remove Entrust provider from x509_certificate_pipe for now.
felixfontein Nov 12, 2020
3b54398
Add own CA tests.
felixfontein Nov 12, 2020
7ecbaa7
One more fix for Entrust provider, when csr_content is used.
felixfontein Nov 12, 2020
4f73eb8
Update plugins/modules/x509_certificate_pipe.py
felixfontein Nov 12, 2020
14decd2
Fix another broken example.
felixfontein Nov 12, 2020
371d3d0
Revert "Remove Entrust provider from x509_certificate_pipe for now."
felixfontein Nov 12, 2020
a5f5424
ci_complete
felixfontein Nov 15, 2020
eea5a0d
Apply suggestions from code review
felixfontein Nov 19, 2020
95b9c46
Improve example.
felixfontein Nov 19, 2020
670b01d
Improve readability of example, add another one.
felixfontein Nov 19, 2020
815ca1b
Extend descriptions of csr_* for selfsigned.
felixfontein Nov 19, 2020
70e3900
Improve documentation.
felixfontein Nov 22, 2020
1b74d24
Move deprecation message up.
felixfontein Nov 24, 2020
14a0ca7
Explain empty choices.
felixfontein Nov 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/135-x509_certificate-entrust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- "x509_certificate - fix ``entrust`` provider, which was broken since community.crypto 0.1.0 due to a feature added before the collection move (https://github.com/ansible-collections/community.crypto/pull/135)."
4 changes: 4 additions & 0 deletions changelogs/fragments/privatekey-csr-certificate-refactoring.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
minor_changes:
- "openssl_privatekey - refactor module to allow code re-use by openssl_privatekey_pipe (https://github.com/ansible-collections/community.crypto/pull/119)."
- "openssl_csr - refactor module to allow code re-use by openssl_csr_pipe (https://github.com/ansible-collections/community.crypto/pull/123)."
- "x509_certificate - refactor module to allow code re-use by x509_certificate_pipe (https://github.com/ansible-collections/community.crypto/pull/135)."
587 changes: 587 additions & 0 deletions plugins/doc_fragments/module_certificate.py
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions plugins/doc_fragments/module_csr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,9 +259,11 @@ class ModuleDocFragment(object):
OCSP Must Staple is as requested, and if the request was signed by the given private key.
seealso:
- module: community.crypto.x509_certificate
- module: community.crypto.x509_certificate_pipe
- module: community.crypto.openssl_dhparam
- module: community.crypto.openssl_pkcs12
- module: community.crypto.openssl_privatekey
- module: community.crypto.openssl_privatekey_pipe
- module: community.crypto.openssl_publickey
- module: community.crypto.openssl_csr_info
'''
2 changes: 2 additions & 0 deletions plugins/doc_fragments/module_privatekey.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,9 @@ class ModuleDocFragment(object):
default: full_idempotence
seealso:
- module: community.crypto.x509_certificate
- module: community.crypto.x509_certificate_pipe
- module: community.crypto.openssl_csr
- module: community.crypto.openssl_csr_pipe
- module: community.crypto.openssl_dhparam
- module: community.crypto.openssl_pkcs12
- module: community.crypto.openssl_publickey
Expand Down
Loading