Promote wins_dns_zone Module from community #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ The docsite for this PR is available for download as an artifact from this run: You can compare to the docs for the File changes:
Click to see the diff comparison.NOTE: only file modifications are shown here. New and deleted files are excluded. diff --git a/home/runner/work/ansible.windows/ansible.windows/docsbuild/base/collections/ansible/windows/index.html b/home/runner/work/ansible.windows/ansible.windows/docsbuild/head/collections/ansible/windows/index.html
index b136da4..2ee2478 100644
--- a/home/runner/work/ansible.windows/ansible.windows/docsbuild/base/collections/ansible/windows/index.html
+++ b/home/runner/work/ansible.windows/ansible.windows/docsbuild/head/collections/ansible/windows/index.html
@@ -170,6 +170,7 @@
<li><p><a class="reference internal" href="win_copy_module.html#ansible-collections-ansible-windows-win-copy-module"><span class="std std-ref">win_copy module</span></a> – Copies files to remote locations on windows hosts</p></li>
<li><p><a class="reference internal" href="win_dns_client_module.html#ansible-collections-ansible-windows-win-dns-client-module"><span class="std std-ref">win_dns_client module</span></a> – Configures DNS lookup on Windows hosts</p></li>
<li><p><a class="reference internal" href="win_dns_record_module.html#ansible-collections-ansible-windows-win-dns-record-module"><span class="std std-ref">win_dns_record module</span></a> – Manage Windows Server DNS records</p></li>
+<li><p><a class="reference internal" href="win_dns_zone_module.html#ansible-collections-ansible-windows-win-dns-zone-module"><span class="std std-ref">win_dns_zone module</span></a> – Manage Windows Server DNS Zones</p></li>
<li><p><a class="reference internal" href="win_domain_module.html#ansible-collections-ansible-windows-win-domain-module"><span class="std std-ref">win_domain module</span></a> – Ensures the existence of a Windows domain <strong class="ansible-deprecation-marker">DEPRECATED: REMOVED IN 3.0.0</strong></p></li>
<li><p><a class="reference internal" href="win_domain_controller_module.html#ansible-collections-ansible-windows-win-domain-controller-module"><span class="std std-ref">win_domain_controller module</span></a> – Manage domain controller/member server state for a Windows host <strong class="ansible-deprecation-marker">DEPRECATED: REMOVED IN 3.0.0</strong></p></li>
<li><p><a class="reference internal" href="win_domain_membership_module.html#ansible-collections-ansible-windows-win-domain-membership-module"><span class="std std-ref">win_domain_membership module</span></a> – Manage domain/workgroup membership for a Windows host <strong class="ansible-deprecation-marker">DEPRECATED: REMOVED IN 3.0.0</strong></p></li>
diff --git a/home/runner/work/ansible.windows/ansible.windows/docsbuild/base/collections/ansible/windows/win_dns_record_module.html b/home/runner/work/ansible.windows/ansible.windows/docsbuild/head/collections/ansible/windows/win_dns_record_module.html
index 4b974a2..6e233c8 100644
--- a/home/runner/work/ansible.windows/ansible.windows/docsbuild/base/collections/ansible/windows/win_dns_record_module.html
+++ b/home/runner/work/ansible.windows/ansible.windows/docsbuild/head/collections/ansible/windows/win_dns_record_module.html
@@ -22,7 +22,7 @@
<script src="../../../_static/sphinx_highlight.js?v=dc90522c"></script>
<script src="../../../_static/js/theme.js"></script>
<link rel="search" title="Search" href="../../../search.html" />
- <link rel="next" title="ansible.windows.win_domain module – Ensures the existence of a Windows domain" href="win_domain_module.html" />
+ <link rel="next" title="ansible.windows.win_dns_zone module – Manage Windows Server DNS Zones" href="win_dns_zone_module.html" />
<link rel="prev" title="ansible.windows.win_dns_client module – Configures DNS lookup on Windows hosts" href="win_dns_client_module.html" /><!-- extra head elements for Ansible beyond RTD Sphinx Theme -->
@@ -432,7 +432,7 @@ see <a class="reference internal" href="#ansible-collections-ansible-windows-win
<footer><div class="rst-footer-buttons" role="navigation" aria-label="Footer">
<a href="win_dns_client_module.html" class="btn btn-neutral float-left" title="ansible.windows.win_dns_client module – Configures DNS lookup on Windows hosts" accesskey="p" rel="prev"><span class="fa fa-arrow-circle-left" aria-hidden="true"></span> Previous</a>
- <a href="win_domain_module.html" class="btn btn-neutral float-right" title="ansible.windows.win_domain module – Ensures the existence of a Windows domain" accesskey="n" rel="next">Next <span class="fa fa-arrow-circle-right" aria-hidden="true"></span></a>
+ <a href="win_dns_zone_module.html" class="btn btn-neutral float-right" title="ansible.windows.win_dns_zone module – Manage Windows Server DNS Zones" accesskey="n" rel="next">Next <span class="fa fa-arrow-circle-right" aria-hidden="true"></span></a>
</div>
<hr/>
diff --git a/home/runner/work/ansible.windows/ansible.windows/docsbuild/base/collections/ansible/windows/win_domain_module.html b/home/runner/work/ansible.windows/ansible.windows/docsbuild/head/collections/ansible/windows/win_domain_module.html
index 77a7e9f..a65dc50 100644
--- a/home/runner/work/ansible.windows/ansible.windows/docsbuild/base/collections/ansible/windows/win_domain_module.html
+++ b/home/runner/work/ansible.windows/ansible.windows/docsbuild/head/collections/ansible/windows/win_domain_module.html
@@ -23,7 +23,7 @@
<script src="../../../_static/js/theme.js"></script>
<link rel="search" title="Search" href="../../../search.html" />
<link rel="next" title="ansible.windows.win_domain_controller module – Manage domain controller/member server state for a Windows host" href="win_domain_controller_module.html" />
- <link rel="prev" title="ansible.windows.win_dns_record module – Manage Windows Server DNS records" href="win_dns_record_module.html" /><!-- extra head elements for Ansible beyond RTD Sphinx Theme -->
+ <link rel="prev" title="ansible.windows.win_dns_zone module – Manage Windows Server DNS Zones" href="win_dns_zone_module.html" /><!-- extra head elements for Ansible beyond RTD Sphinx Theme -->
@@ -381,7 +381,7 @@ To check whether it is installed, run <code class="code docutils literal notrans
<footer><div class="rst-footer-buttons" role="navigation" aria-label="Footer">
- <a href="win_dns_record_module.html" class="btn btn-neutral float-left" title="ansible.windows.win_dns_record module – Manage Windows Server DNS records" accesskey="p" rel="prev"><span class="fa fa-arrow-circle-left" aria-hidden="true"></span> Previous</a>
+ <a href="win_dns_zone_module.html" class="btn btn-neutral float-left" title="ansible.windows.win_dns_zone module – Manage Windows Server DNS Zones" accesskey="p" rel="prev"><span class="fa fa-arrow-circle-left" aria-hidden="true"></span> Previous</a>
<a href="win_domain_controller_module.html" class="btn btn-neutral float-right" title="ansible.windows.win_domain_controller module – Manage domain controller/member server state for a Windows host" accesskey="n" rel="next">Next <span class="fa fa-arrow-circle-right" aria-hidden="true"></span></a>
</div>
diff --git a/home/runner/work/ansible.windows/ansible.windows/docsbuild/base/collections/index_module.html b/home/runner/work/ansible.windows/ansible.windows/docsbuild/head/collections/index_module.html
index e0c78c4..7deae75 100644
--- a/home/runner/work/ansible.windows/ansible.windows/docsbuild/base/collections/index_module.html
+++ b/home/runner/work/ansible.windows/ansible.windows/docsbuild/head/collections/index_module.html
@@ -132,6 +132,7 @@
<li><p><a class="reference internal" href="ansible/windows/win_copy_module.html#ansible-collections-ansible-windows-win-copy-module"><span class="std std-ref">ansible.windows.win_copy</span></a> – Copies files to remote locations on windows hosts</p></li>
<li><p><a class="reference internal" href="ansible/windows/win_dns_client_module.html#ansible-collections-ansible-windows-win-dns-client-module"><span class="std std-ref">ansible.windows.win_dns_client</span></a> – Configures DNS lookup on Windows hosts</p></li>
<li><p><a class="reference internal" href="ansible/windows/win_dns_record_module.html#ansible-collections-ansible-windows-win-dns-record-module"><span class="std std-ref">ansible.windows.win_dns_record</span></a> – Manage Windows Server DNS records</p></li>
+<li><p><a class="reference internal" href="ansible/windows/win_dns_zone_module.html#ansible-collections-ansible-windows-win-dns-zone-module"><span class="std std-ref">ansible.windows.win_dns_zone</span></a> – Manage Windows Server DNS Zones</p></li>
<li><p><a class="reference internal" href="ansible/windows/win_domain_module.html#ansible-collections-ansible-windows-win-domain-module"><span class="std std-ref">ansible.windows.win_domain</span></a> – Ensures the existence of a Windows domain <strong class="ansible-deprecation-marker">DEPRECATED: REMOVED IN 3.0.0</strong></p></li>
<li><p><a class="reference internal" href="ansible/windows/win_domain_controller_module.html#ansible-collections-ansible-windows-win-domain-controller-module"><span class="std std-ref">ansible.windows.win_domain_controller</span></a> – Manage domain controller/member server state for a Windows host <strong class="ansible-deprecation-marker">DEPRECATED: REMOVED IN 3.0.0</strong></p></li>
<li><p><a class="reference internal" href="ansible/windows/win_domain_membership_module.html#ansible-collections-ansible-windows-win-domain-membership-module"><span class="std std-ref">ansible.windows.win_domain_membership</span></a> – Manage domain/workgroup membership for a Windows host <strong class="ansible-deprecation-marker">DEPRECATED: REMOVED IN 3.0.0</strong></p></li>
|
jborean93
reviewed
Nov 13, 2024
plugins/modules/win_dns_zone.py
Outdated
|
|
||
| EXAMPLES = r''' | ||
| - name: Ensure primary zone is present | ||
| community.windows.win_dns_zone: |
There was a problem hiding this comment.
All the examples need to change from community.windows.win_dns_zone to ansible.windows.win_dns_zone.
There was a problem hiding this comment.
All examples changed to ansible.windows.win_dns_zone
| @@ -0,0 +1 @@ | |||
| shippable/windows/group1 | |||
There was a problem hiding this comment.
Please change to group 2. Based on the nightly run it is quicker than 1 and 3 will now be longer with win_dns_record being merged https://dev.azure.com/ansible/ansible.windows/_build/results?buildId=128352&view=results.
There was a problem hiding this comment.
Should we apply this change to all modules?
There was a problem hiding this comment.
No just for this one, we need to try and keep things balanced so it doesn’t exceed 45 minutes.
| state: present | ||
|
|
||
| - name: Ensure domain is present | ||
| ansible.windows.win_domain: |
There was a problem hiding this comment.
We should try and use microsoft.ad.domain module here. I'll try and submit a PR to add it as a test requirement as it is somewhat complicated to get it set up.
There was a problem hiding this comment.
#691 has been merged so now microsoft.ad is available in the integration tests.
Updating tasks to use modules that migrated to windows.ad repo. Signed-off-by: hyaish <[email protected]>
Yaish25491
force-pushed
the
ANSTRAT-977
branch
from
1a028d8
to
085dfb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating tasks to use modules that migrated to Windows.ad repo.
SUMMARY
Updating tasks to use modules that migrated to Windows.ad repo.
Verifying modules on Windows Server 2019 and Windows Server 2022
ISSUE TYPE
COMPONENT NAME
win_dns_zone.ps1
win_dns_zone.py
win_dns_zone/aliases
win_dns_zone/defaults/main.yml
win_dns_zone/tasks/activedirectory.yml
win_dns_zone/tasks/main.yml
win_dns_zone/tasks/standalone.yml
ADDITIONAL INFORMATION
Migrating Win_dns_zone from community to ansible.windows