pre-genesis #8
Closed
pre-genesis #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskay
requested changes
Aug 21, 2024
There was a problem hiding this comment.
toml itself looks good! but
- looks like you accidentally included the same file under two different names
- I believe the CI checks require the name in the file (stakepool) to match your github name (Michel-Leidson). so either change the filename or submit from your stakepool github
once these are taken care of we can merge
|
Done! |
|
Ty! it's still failing but I believe due to a CI issue on our end... once we resolve that I expect it to pass |
|
Thanks a lot! |
|
We've pushed a fix for the CI bug, can you try rebasing to latest to see if the checks pass? |
|
Yes, of course. Done! |
Fraccaman
previously approved these changes
Aug 22, 2024
|
I closed the pr: And reopen a new one #54 with new changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StakePool
https://stakepool.dev.br/