feat: add header to debug chunk load #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierJp
approved these changes
Nov 7, 2024
It is directly set by Nextjs and it includes a date (that is somewhat equivalent to a buildid, enabling us to detect with which build the response has been made). |
If we get a 404 chunk load, but the new header is from the old build, we will know it is a cache related problem. |
rmonnier9
force-pushed
the
debug-chunk-load
branch
from
d22ee3c
to
a601305
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ajout d'un header sur les chunk loads pour identifier sur quelle instance et sur quel build (en utilisant la date de build) a été créé une réponse.
Cela permettra d'identifier si il y a un problème de mise en cache au niveau de l'infra.