Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mobile header menu #1070

Merged
merged 2 commits into from
May 29, 2024
Merged

fix: mobile header menu #1070

merged 2 commits into from
May 29, 2024

Conversation

johangirod
Copy link
Contributor

fix #1020

@johangirod johangirod marked this pull request as ready for review May 28, 2024 07:39
XavierJp
XavierJp approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@XavierJp XavierJp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the old style but this works.

Before merging can you please add back the hover effect on "se connecter/agentpublic" and maybe align modal with hover border ?

@johangirod johangirod requested a review from XavierJp May 28, 2024 17:11
@XavierJp XavierJp merged commit e3ffcd6 into main May 29, 2024
8 checks passed
@XavierJp XavierJp deleted the 1020-mobile-logout branch May 29, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierJp XavierJp XavierJp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Header mobile : pas de login / logout
2 participants
@johangirod @XavierJp