Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Move association and protected certificat to server component" #1053

Merged
merged 1 commit into from
May 15, 2024
Merged

Revert "Move association and protected certificat to server component" #1053

merged 1 commit into from
May 15, 2024

Conversation

XavierJp
Copy link
Contributor

@XavierJp XavierJp commented May 15, 2024 •
edited
Loading

Reverts #1052

I revert this as :

  • many loader are missing
  • there is an issue when no components get rendered when no results
  • page certificat is broken (currently only displaying an error on Qualibat which can create a false impression that every company is Qualibat)

@XavierJp XavierJp requested a review from johangirod May 15, 2024 07:16
@XavierJp XavierJp merged commit 7ad8552 into main May 15, 2024
8 checks passed
@XavierJp XavierJp deleted the revert-1052-TMP-server-component-streaming branch May 15, 2024 07:19
@XavierJp XavierJp mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johangirod johangirod Awaiting requested review from johangirod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@XavierJp