fix: timetracking field always marshalled #768
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the field for timetracking is always marshalled to JSON even if the "OriginalEstimate" field is an empty string. This is because of the way the field is initialized as a struct that will never be nil and therefore never caught by the 'omitempty' tag. This changes the TimeTracking field to be a pointer, which is nil by default, so that if OriginalEstimate isn't set, the timetracking field won't be in the JSON sent to Jira. This is a problem if the issue type being created is one that doesn't support a timetracking field.
|
I will look at fixing tests soon. |
|
🤦♂️ I should've checked open PRs. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the new field from #748 for timetracking is always marshalled to JSON even if the "OriginalEstimate" field is an empty string.
This is because of the way the field is initialized as a struct that will never be nil and therefore never caught by the 'omitempty' tag.
This changes the TimeTracking field to be a pointer, which is nil by default, so that if OriginalEstimate isn't set, the timetracking field won't be in the JSON sent to Jira.
This is a problem if the issue type being created is one that doesn't support a timetracking field.