Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 2.17 release changelog #123

Merged
merged 1 commit into from
Feb 23, 2024
Merged

feat: 2.17 release changelog #123

merged 1 commit into from
Feb 23, 2024

Conversation

mikehardy
Copy link
Member

Went through this on google docs already a ton with David

worked on it locally in asciidoc format afterwards with edit/render cycles until it appeared to look good

Posting up here with a soft-approve from David already, checking rendering and re-re-reviewing it

will merge ASAP to get the release kicked off

@mikehardy mikehardy force-pushed the 217-changelog branch 3 times, most recently from 87e1a4a to 5afbb3e Compare February 23, 2024 16:46
@mikehardy
Copy link
Member Author

Done with obvious formatting errors, all links checked and they load desired target correctly (one was subtle!)
Going to take a break then re-re-re-read it again, the if it looks good merge and start 2.17 release

* Bug Fixes
** Too many to mention! Hundreds of issues fixed. https://github.com/ankidroid/Anki-Android/milestone/51?closed=1[See the full changelog]
* Release Statistics:
** link:++https://github.com/ankidroid/Anki-Android/compare/v2.16.5...main++[958 changes from 26 contributors since 2.16]
Copy link
Member Author

@mikehardy mikehardy Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one was really subtle! the target kept getting html-entitified on the ..., using ++ to enclose it passed it through asciidoctor correctly

@mikehardy
Copy link
Member Author

post-break re-read, found some tiny tiny things, I can no longer see anything. Render check is 💯 locally. Good (enough) to go.

We can always do follow-ons after

@mikehardy mikehardy merged commit 96ab122 into main Feb 23, 2024
2 checks passed
@mikehardy mikehardy deleted the 217-changelog branch February 23, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant