Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent Toolbar background color #17146

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

gayatriii0803
Copy link
Contributor

Purpose / Description

The toolbar background color should not be blue, it should be black in Black/Dark theme

Fixes

Approach

Fix inconsistent Toolbar background by replacing colorPrimary with appBarColor

How Has This Been Tested?

WhatsApp Image 2024-09-27 at 5 40 20 PM

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@rohit9625
Copy link

I think you should make top bar color blend with the content.

@lukstbit lukstbit added the Needs Second Approval Has one approval, one more approval to merge label Sep 29, 2024
@david-allison david-allison added this pull request to the merge queue Sep 29, 2024
Merged via the queue into ankidroid:main with commit 249b288 Sep 29, 2024
12 checks passed
@github-actions github-actions bot removed the Needs Second Approval Has one approval, one more approval to merge label Sep 29, 2024
@github-actions github-actions bot added this to the 2.19 release milestone Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Inconsistent Toolbar background color
4 participants