Language name starts with a upper case #17121
Conversation
There was a problem hiding this comment.
Two are incorrect (to my understanding). I used https://en.wikipedia.org/wiki/List_of_ISO_639_language_codes
Do we have this data anywhere in CLDR?
| "Venda" to "ve", // Venda | ||
| "Tiếng Việt" to "vi", // Vietnamese | ||
| "Wolof" to "wo", // Wolof | ||
| "isiXhosa" to "xh", // Xhosa | ||
| "IsiXhosa" to "xh", // Xhosa |
There was a problem hiding this comment.
https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry which is referenced by your first wikipedia link only use "Xhosa" while the second link indeed uses isiXhosa.
| "հայերեն (Հայաստան)" to "hy-AM", // Armenian (Armenia) | ||
| "Hrvatski" to "hr", // Croatian | ||
| "Magyar" to "hu", // Hungarian | ||
| "Hայերեն (Հայաստան)" to "hy-AM", // Armenian (Armenia) |
| "اردو (پاکستان)" to "ur-PK", // Urdu (Pakistan) | ||
| "o‘zbek" to "uz", // Uzbek | ||
| "O‘zbek" to "uz", // Uzbek |
There was a problem hiding this comment.
O‘zbek is not on Wikipedia as an Endonym
|
I applied your comment. Honestly, I'm not exactly sure where to get confirmation, appart from waiting for translators to provide feedback through crowdin. I don't expect to easily find native Uzbek` speaker for example |
|
I flagged potential issues. Stick with the CLDR-proposed names unless you've confirmed either way |
|
Note: only one comment was addressed |
david-allison
added
squash-merge
The menu provided to the users to select their languages is not yet perfect. It's hard to know for certain what is the correct way to display the languages to the users. The function provided by Android was buggy, and so, a year and a half ago, the language names were hard-coded in ankidroid#13275. Except that nobody speaks the 93 languages in which we have translations available. On the long term, I hope that 92 translators will provide 92 language string to use. ankidroid#17120 should start the process to eventually fix this error. On the short term, there is one change that we can make that will probably be, on average, an improvement. Using upper case for the first letter of each name. If I understand correctly Brayan's comment, this change would be correct for Portuguese. I can confirm it's correct for French. I can't promise this won't make things worse for some language. But, if we got some right previously, it was by accident, and I still hope this is, on average, an improvement. The upper cases were obtained by using the "set first later to upper case" feature of emacs on each language name. íslenska, isiXhosa and isiZulu appear to start with lowercase letters so these have not been updated Fixed: ankidroid#17118 Co-authored-by: David Allison <[email protected]>
Santali and Sardinian were written in English, rather than their respective languages These values were obtained using `ULocale`. Sources (Unicode CLDR): * `ᱥᱟᱱᱛᱟᱲᱤ` - https://github.com/unicode-org/cldr/blob/731f226f93f95635500bbbadccf96798c23e4c9a/common/main/sat.xml#L365C25-L365C32 * `sardu` - https://github.com/unicode-org/cldr/blob/731f226f93f95635500bbbadccf96798c23e4c9a/common/main/sc.xml#L369C24-L369C29 * Casing rules do not appear in CLDR yet, but I assume that uppercasing the name is OK Co-authored-by: David Allison <[email protected]>
david-allison
force-pushed
the
upper_case
branch
from
42850c4
to
99e8fce
Compare
david-allison
removed
the
squash-merge
|
@Arthur-Milchior I've squashed the commits and force pushed. I've added additional information to the first commit message, and written the second. When feasible, could you review my changes and confirm you're happy with them, given I've set you as the author on both |
Language name starts with a upper case
The menu provided to the users to select their languages is not yet
perfect. It's hard to know for certain what is the correct way to
display the languages to the users. The function provided by Android
was buggy, and so, a year and a half ago, the language names were
hard-coded in #13275. Except that nobody speaks the 93 languages in
which we have translations available.
On the long term, I hope that 92 translators will provide 92 language
string to use. #17120 should start the process to eventually fix this
error.
On the short term, there is one change that we can make that will
probably be, on average, an improvement. Using upper case for the
first letter of each name.
If I understand correctly Brayan's comment, this change would be
correct for Portugese. I can confirm it's correct for French. I can't
promise this won't make things worse for some language. But, if we got
some right previously, it was by accident, and I still hope this is,
on average, an improvement.
The upper cases were obtained by using the "set first later to upper
case" feature of emacs on each language name.