Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve alert dialog style #16549

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Conversation

MorenoTropical
Copy link
Contributor

@MorenoTropical MorenoTropical commented Jun 4, 2024

Purpose / Description

The dialogs didn't look much like material dialogs, so I applied the overlay theme to get animations, round corners and material style

Fixes

Approach

I used Material Dialog Theme Overlay and did a fix with the text color

I was going to remove AlertDialogStyle as well but someone else is doing something with it

How Has This Been Tested?

image

image

image

dialog.webm
light.webm
API.25.webm

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison

This comment was marked as off-topic.

Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the videos are helpful it would be better if you could supply several images for dialogs where we have a before and after side by side so it's easy to see the differences.

AnkiDroid/src/main/res/values/dimens.xml Outdated Show resolved Hide resolved
AnkiDroid/src/main/res/values/styles.xml Show resolved Hide resolved
AnkiDroid/src/main/res/values/styles.xml Show resolved Hide resolved
@lukstbit lukstbit added the Needs Author Reply Waiting for a reply from the original author label Jun 5, 2024
@MorenoTropical MorenoTropical force-pushed the dialog-style branch 2 times, most recently from 049efdd to 72bce15 Compare June 5, 2024 10:04
@neeldoshii

This comment was marked as resolved.

@MorenoTropical

This comment was marked as resolved.

@BrayanDSO BrayanDSO removed the Needs Author Reply Waiting for a reply from the original author label Jun 7, 2024
@BrayanDSO
Copy link
Member

The code changes themselves are fine, but it needs a manual check of the other dialogs. The app has many of them and some are relatively complex or not follow some of the best practices for styling.

An automated screenshot tool would really help here.

it was purple in dark mode

tested by showing the delete note dialog in the reviewer
it was purple in dark mode

tested by showing the delete note dialog in the reviewer
@MorenoTropical
Copy link
Contributor Author

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

@MorenoTropical
Copy link
Contributor Author

@lukstbit @BrayanDSO please take a look or tell me what to do do

Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Sep 9, 2024
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, with (as far as I can tell, and I was trying...) all comments addressed with reasonable support

This statement may be due for review and perhaps a follow-on now that GSoC is merged (I think - most are merged, hopefully the ones that were interfering with this are merged):

I was going to remove AlertDialogStyle as well but someone else is doing something with it

@mikehardy mikehardy added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Sep 16, 2024
@mikehardy mikehardy dismissed lukstbit’s stale review September 16, 2024 14:30

I believe comments were addressed

@mikehardy mikehardy added this pull request to the merge queue Sep 16, 2024
Merged via the queue into ankidroid:main with commit 2ac565a Sep 16, 2024
9 checks passed
@github-actions github-actions bot added this to the 2.19 release milestone Sep 16, 2024
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Change color of Checkbox in AlertDialog
6 participants