Make permission item fully touchable

[gayatriii0803]

Purpose / Description

In PermissionActivity, the permission item is not fully touchable, unlike in the settings.

Approach

setOnClickListener on root layout.

How Has This Been Tested?

WhatsApp.Video.2024-06-07.at.20.38.22_93f151fb.mp4

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[criticalAY]

If you are setting the onClick listener to the root layout, then it would be best to remove the redundant code from the switch listener ? I might be wrong but if the layouts can be merged then it can only be set to the parent layout

[ShridharGoel]

Can you add a video? Also, did you test if the switch is unchecked when declined?

[gayatriii0803]

did you test if the switch is unchecked when declined?

Yes

[BrayanDSO]

If the whole element is going to be a touch area, it needs some kind of visual feedback, like a Setting does.

[criticalAY]

As I said earlier the views need to be merged, right now the switch if tapped does nothing, the linear layout takes to the permission screen but the switch
Here the view are independent:

[gayatriii0803]

@criticalAY I don't understand will you please explain what actually i have to do.

[criticalAY]

Tap the switch, nothing happens. It will work only if you tap the layout i.e. the switch/layout should both be tappable and lead to same action

[gayatriii0803]

I request maintainers to open this PR and review

[criticalAY]

Comments need to be resolved

[gayatriii0803]

@criticalAY Comment already resolve kindly check once again.

[david-allison]

@criticalAY

[criticalAY]

Works as expected! apologies for the wrong label

[BrayanDSO]

Repeating myself:

If the whole element is going to be a touch area, it needs some kind of visual feedback, like a Setting does.

[gayatriii0803]

Please reopen this PR

[gayatriii0803]

it needs some kind of visual feedback, like a Setting does

@BrayanDSO What do you mean by visual feedback? I don't understand. Will you please explain again?

[BrayanDSO]

When you press a setting, there's a gray animation that flows like a wave that acts as feedback. So, something like that.