-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#12451 Issue: Replace string with plurals #13616
#12451 Issue: Replace string with plurals #13616
Conversation
First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible. |
Message to maintainers, this PR contains strings changes.
Read more about updating strings on the wiki, |
Thanks for the PR!! 🙏 Please change the string keys if you're changing values The CI is failing, could you look into this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI needs fixing
Of the 8 PluralCandidates, first and last one don't need to be changed to plurals. |
739408e
to
1ce1aaf
Compare
@david-allison |
e99d3ba
to
ca8c691
Compare
Hi @david-allison |
String key pairs have been changed by adding '_new" to the key. Ex. name = "string_key" to name = "string_key_new" Final Updates for Plural Candidates
da53fc2
to
23d03df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look good to me. I removed the merge commit, rebased to current main and re-pushed, plus committed one small text change, if CI passes I think this can go in
* Fix: ankidroid#12451 Issue: Replace string with plurals String key pairs have been changed by adding '_new" to the key. Ex. name = "string_key" to name = "string_key_new" Final Updates for Plural Candidates * disambiguate apostrophe with expansion of text --------- Co-authored-by: Mike Hardy <[email protected]>
Hi there @Aayush-Goel-04! This is the OpenCollective Notice for PRs merged from 2023-06-01 through 2023-06-30 If you are interested in compensation for this work, the process with details is here: https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month Please note that GSoC contributions are okay for this process. Our philosophy is that our users have donated to AnkiDroid for all contributions. The only PRs that will not go through the OpenCollective process are ones directly related to am accepted GSoC project from a selected participant, since those receive a stipend from GSoC itself. Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding. Thanks! |
Checklist
Fixes #12451