Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Astana capital again #571

Merged
merged 3 commits into from
Oct 10, 2022
Merged

Make Astana capital again #571

merged 3 commits into from
Oct 10, 2022

Conversation

KentGrigo
Copy link
Contributor

The capital of Kazakhstan has been changed back from Nur-Sultan to Astana as of September 2022:
https://www.theguardian.com/world/2022/sep/14/kazakhstan-to-change-name-of-capital-from-nur-sultan-back-to-astana

As the names just needed to be swapped, I tried to change it for all the languages.
But it'd be nice if someone with more knowledge about these various languages could double check the correctness.

@KentGrigo KentGrigo changed the title feat: Make Astana capital again Make Astana capital again Oct 8, 2022
@aplaice aplaice merged commit daffebe into anki-geo:master Oct 10, 2022
@aplaice
Copy link
Collaborator

aplaice commented Oct 10, 2022

Merging to move forward. I'm still in favour of a range (possibly with a month, as before), but we can add that later, perhaps as part of #545.

(Alternatively, if the name is changed back again, we can revert this. :))


I forgot to add a Fix #n keyword, while merging :/

@aplaice aplaice linked an issue Oct 10, 2022 that may be closed by this pull request
@aplaice
Copy link
Collaborator

aplaice commented Oct 10, 2022

Oops; checking the translations (I thought that I had checked them previously and hence only looked through cursorily today), I think that the Spanish and Portuguese translations are wrong, with an unnecessary de. (The de was in the previous translation as part of marzo de 2019 ("March of 2019") and similarly for Portuguese.)

The Czech translation also has an unnecessary/wrong month (březen is March).

Edit: the gender is also wrong for Czech, Polish and Russian, I think. (Astana is female, unlike Nursultan.)

@axelboc axelboc added the content Content changes, map improvements, translation fixes, etc. label Dec 21, 2023
@axelboc axelboc added this to the v5.2 milestone Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content changes, map improvements, translation fixes, etc.
Development

Successfully merging this pull request may close these issues.

Kazakhstan capital name is back to Astana
3 participants