Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to make nyaa episodic #551

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

AbdullahM0hamed
Copy link
Collaborator

Couldn't help myself - nyaa must conform.

A lot of testing is needed. To simplify testing, simply replace [('no_extractor', magnet_link)] to [('no_extractor', url)] and check the titles from those links to see that the episodes are being picked up and in the correct order. Episodic must be set to True (set to False by default because this is very experimental).

@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #551 into master will decrease coverage by 0.24%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #551      +/-   ##
==========================================
- Coverage   16.79%   16.54%   -0.25%     
==========================================
  Files         117      117              
  Lines        4580     4647      +67     
==========================================
  Hits          769      769              
- Misses       3811     3878      +67     
Impacted Files Coverage Δ
anime_downloader/config.py 51.78% <ø> (ø)
anime_downloader/sites/nyaa.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021785e...416c384. Read the comment docs.

@IguanasInPyjamas
Copy link
Contributor

Feels runtime man

@AbdullahM0hamed
Copy link
Collaborator Author

Should be much faster now. Scrape_episodes_episodic really needs work though

@codecov-io
Copy link

Codecov Report

Merging #551 (416c384) into master (308a5de) will decrease coverage by 4.23%.
The diff coverage is 4.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #551      +/-   ##
==========================================
- Coverage   20.78%   16.54%   -4.24%     
==========================================
  Files         100      117      +17     
  Lines        3806     4647     +841     
==========================================
- Hits          791      769      -22     
- Misses       3015     3878     +863     
Impacted Files Coverage Δ
anime_downloader/__version__.py 0.00% <0.00%> (ø)
anime_downloader/animeinfo.py 0.00% <0.00%> (ø)
anime_downloader/cli.py 0.00% <0.00%> (ø)
anime_downloader/commands/config.py 0.00% <0.00%> (ø)
anime_downloader/commands/dl.py 0.00% <0.00%> (ø)
anime_downloader/commands/ezdl.py 0.00% <0.00%> (ø)
anime_downloader/commands/test.py 0.00% <0.00%> (ø)
anime_downloader/commands/watch.py 0.00% <0.00%> (ø)
anime_downloader/config.py 51.78% <ø> (ø)
anime_downloader/downloader/http_downloader.py 24.59% <0.00%> (-0.84%) ⬇️
... and 111 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d20769...eaabcf9. Read the comment docs.

@AbdullahM0hamed AbdullahM0hamed marked this pull request as ready for review February 13, 2021 18:17
@AbdullahM0hamed AbdullahM0hamed changed the title [Experimental] Add ability to make nyaa episodic Add ability to make nyaa episodic Feb 13, 2021
@ArjixWasTaken
Copy link
Collaborator

ArjixWasTaken commented Aug 18, 2021

Is this abandoned or not?
I doubt iggy is going to actually give a review as requested.

@AbdullahM0hamed
Copy link
Collaborator Author

AbdullahM0hamed commented Aug 19, 2021

Iirc this was working and I was just waiting on a review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants