-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to make nyaa episodic #551
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #551 +/- ##
==========================================
- Coverage 16.79% 16.54% -0.25%
==========================================
Files 117 117
Lines 4580 4647 +67
==========================================
Hits 769 769
- Misses 3811 3878 +67
Continue to review full report at Codecov.
|
469f9bc
to
cf82202
Compare
Feels runtime man |
Should be much faster now. Scrape_episodes_episodic really needs work though |
382b881
to
eaabcf9
Compare
Codecov Report
@@ Coverage Diff @@
## master #551 +/- ##
==========================================
- Coverage 20.78% 16.54% -4.24%
==========================================
Files 100 117 +17
Lines 3806 4647 +841
==========================================
- Hits 791 769 -22
- Misses 3015 3878 +863
Continue to review full report at Codecov.
|
eaabcf9
to
b16b1f6
Compare
Is this abandoned or not? |
Iirc this was working and I was just waiting on a review |
Couldn't help myself - nyaa must conform.
A lot of testing is needed. To simplify testing, simply replace
[('no_extractor', magnet_link)]
to[('no_extractor', url)]
and check the titles from those links to see that the episodes are being picked up and in the correct order. Episodic must be set to True (set to False by default because this is very experimental).