Skip to content
This repository has been archived by the owner on May 25, 2019. It is now read-only.

Fix multiple compilations from duplicating items in ng-repeat #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

runxc1
Copy link

@runxc1 runxc1 commented Jun 19, 2013

#12

@ProLoser
Copy link
Member

Think you could add a unit test or 2 to show this fixes the bug in question?

@Valorum
Copy link

Valorum commented Jul 23, 2013

Do we need the compile flag & check at all? It seems that simply commenting out lines 73-78 in the original works as expected.

EDIT:

Found that it needs to compile once or else ng-click won't work. Don't need to decorate the infoWindow.open() though; compiling once in the link function seems to suffice. See Valorum@327d7ef

@brooly
Copy link

brooly commented Sep 24, 2013

Can this pull request being merged or the Valorum's one... The issue is still happening

@conorw
Copy link

conorw commented May 16, 2014

This fix works for me, it has stopped the event handlers from multiplying.

@sandcastle
Copy link

+1

@rsantosdev
Copy link

@Valorum fix worked fine for me, please accept that

@sandcastle
Copy link

Any update on if this will be accepted? - its been open for over a year now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants