Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nf): Use es module shims fully instead of global cache not in sync #517

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jogelin
Copy link
Contributor

@jogelin jogelin commented Mar 16, 2024

Split of #513

Description

For now, the importmap is only used for resolving the shared library. Adding the exposes to it does not change anything because a custom global cache is used to store the remotes and consumed by loadRemote.

Then the importShims is used only to load an URL. It could be used with the key of the exposes like importShims('mfe1/Component') and then the resolution of the URL is automatic.

In this PR, I wanted to simplify by:

  • no need to write an importmap into the DOM if it is used partially
  • fix the fact that the es-module-shims could be not in sync with the custom global cache
  • Use importShims('mfe1/Component') like a javascript imports instead of using the baseUrl

@jogelin jogelin marked this pull request as ready for review March 16, 2024 07:19
@jogelin jogelin changed the title [TBD] feat(nf): Use es module shims fully instead of global cache not in sync feat(nf): Use es module shims fully instead of global cache not in sync Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant