Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Public IP detection - Fix issue when seeip.org is unreachable #1241 #1243

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix Public IP detection - Fix issue when seeip.org is unreachable #1241 #1243

wants to merge 5 commits into from

Conversation

ralphg6
Copy link

@ralphg6 ralphg6 commented Aug 10, 2024 •
edited
Loading

The script does work when seeip.org is unreachable, so I changed the policy to define the public IP.

It solves the issue #1241

CHANGELOG

Added

  • Timeout limit on each try to solve the IP to avoid long waits;
  • Extra public IP providers as failovers;

Changed

  • the script only will try to solve an IP if the ENDPOINT is empty;

Removed

  • Unneeded output of CURL commands on IP detection;
  • Duplicated code;

@ralphg6 ralphg6 mentioned this pull request Aug 10, 2024
Open
@ralphg6
Copy link
Author

ralphg6 commented Aug 10, 2024

Solves #1241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaz alaz alaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ralphg6 @alaz