Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements a degraded state detection for LavalinkClusterNode #180

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

SKProCH
Copy link
Collaborator

@SKProCH SKProCH commented Sep 11, 2024

When the socket looses the connection to node, clustered node status should became Degraded. When connection established again, status should return back to Available.

I'm actually doesn't quite happy with the implementation, since SocketConnectionReady kinda duplicates already existent ready task in socket, but at the moment when socket fires the ConnectionClosed, LavalinkNode doesn't recreate the ready TaskCompletitionSource yet, so awaiting it in cluster node will be immediately completed.

@SKProCH SKProCH added enhancement New feature or request .NET Pull requests that update .net code labels Sep 11, 2024
@SKProCH SKProCH self-assigned this Sep 11, 2024
Copy link

Delta Summary

Generated on: 09/11/2024 - 22:14
Description Previous Current Delta
Coverage date: 09/08/2024 - 16:46 09/11/2024 - 22:14
Line coverage: 66.5% 66.4% -0.1%
Covered lines: 14692 14700 8
Coverable lines: 22092 22106 14
Total lines: 60549 60577 28
Branch coverage: 51.1% 51.2% 0.1%
Covered branches: 2512 2514 2
Total branches: 4909 4909 0
Method coverage: Feature is only available for sponsors

@SKProCH SKProCH merged commit c8be66b into dev Sep 12, 2024
4 checks passed
@SKProCH SKProCH deleted the degradedStateDetection branch September 12, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants