fix: Fix race condition

angelobreuer · Aug 21, 2023 · 5a8de7b · 5a8de7b
1 parent 6a65795
commit 5a8de7b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/Lavalink4NET.Tests/LavalinkNodeTests.cs b/src/Lavalink4NET.Tests/LavalinkNodeTests.cs
@@ -545,9 +545,8 @@ public void Complete()
 				.WaitAsync(_shutdownCancellationTokenSource.Token)
 				.ConfigureAwait(false);
 		}
-		catch (Exception exception)
+		catch
 		{
-			var k = exception;
 			if (_flushSemaphoreSlim.CurrentCount is 0)
 			{
 				_flushSemaphoreSlim.Release();

diff --git a/src/Lavalink4NET/LavalinkNode.cs b/src/Lavalink4NET/LavalinkNode.cs
@@ -449,6 +449,13 @@ private async Task ReceiveInternalAsync(ClientInformation clientInformation, Can
 
 		while (!_shutdownCancellationToken.IsCancellationRequested)
 		{
+			if (_readyTaskCompletionSource.Task.IsCompleted)
+			{
+				// Initiate reconnect
+				_readyTaskCompletionSource = new TaskCompletionSource<string>(
+					creationOptions: TaskCreationOptions.RunContinuationsAsynchronously);
+			}
+
 			var socketOptions = new LavalinkSocketOptions
 			{
 				Label = Label,
@@ -472,10 +479,6 @@ private async Task ReceiveInternalAsync(ClientInformation clientInformation, Can
 			_ = socket.RunAsync(socketCancellationSource.Token).AsTask();
 
 			await ReceiveInternalAsync(socket, cancellationToken).ConfigureAwait(false);
-
-			// Initiate reconnect
-			_readyTaskCompletionSource = new TaskCompletionSource<string>(
-				creationOptions: TaskCreationOptions.RunContinuationsAsynchronously);
 		}
 	}