Create release endpoint #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyronx
reviewed
Sep 26, 2023
tyronx
reviewed
Sep 26, 2023
tyronx
reviewed
Sep 26, 2023
|
any chance you could test this still? |
|
Hello, I've tried to set it up once again, but neither docker nor Remote Containers work for me. I can't get the website running even on the master branch and therefore can't test this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18
I've never worked with php before and wasn't able to get project running(it always responds with ERR_CONNECTION_REFUSED) so there are few things I need help with:
1. I left 3 TODO comments on parts of code that I'm not sure are correct.2. Since I wasn't able to run it, I can't test it either.
3. New post method uses web session token for authentication, but this token only lives for 2 weeks. We want to add a page/endpoint that allows to generate an API key(just like session token on login) for a user that won't expire.