Skip to content

Commit

Permalink
KEP-2170: Add the apiGroup to the TrainingRuntimeRef (kubeflow#2201)
Browse files Browse the repository at this point in the history
Signed-off-by: Yuki Iwai <[email protected]>
  • Loading branch information
tenzen-y authored Aug 9, 2024
1 parent 94140ed commit 725b09e
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions docs/proposals/2170-kubeflow-training-v2/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -317,13 +317,18 @@ type TrainJobSpec struct {
}

type TrainingRuntimeRef struct {
// Name for the runtime.
// Name is the name of the runtime being referenced.
// This must indicate the runtime deployed in the same namespace as the TrainJob
// when TrainingRuntime is used in the kind.
Name string `json:"name"`

// Kind for the runtime, which must be TrainingRuntime or ClusterTrainingRuntime.
// Defaults to the ClusterTrainingRuntime.
// APIGroup is the group of the runtime being referenced.
// Defaults to 'kubeflow.org'.
APIGroup *string `json:"apiGroup,omitempty"`

// Kind is the kind of the runtime being referenced.
// The value must be TrainingRuntime or ClusterTrainingRuntime when the 'kubeflow.org' is used in the apiGroup.
// Defaults to the ClusterTrainingRuntime when the 'kubeflow.org' is used in the apiGroup.
Kind *string `json:"kind,omitempty"`
}

Expand Down

0 comments on commit 725b09e

Please sign in to comment.