Skip to content

Commit

Permalink
[SDK] Fix Failed condition in wait Job API
Browse files Browse the repository at this point in the history
Signed-off-by: Andrey Velichkevich <[email protected]>
  • Loading branch information
andreyvelich committed Jul 11, 2024
1 parent 2b39d3c commit 09ba2d1
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions sdk/python/kubeflow/training/api/training_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -871,7 +871,8 @@ def wait_for_job_conditions(
Raises:
ValueError: Invalid input parameters.
TimeoutError: Timeout to get Job.
RuntimeError: Failed to get Job or Job reaches unexpected Failed condition.
RuntimeError: Failed to get Job, or Job reaches Failed condition and
Failed is not in `expected_conditions` set.
"""

namespace = namespace or self.namespace
Expand Down Expand Up @@ -904,9 +905,9 @@ def wait_for_job_conditions(
if callback:
callback(job)

# Raise an exception if Job is Failed and Failed is not expected condition.
# Raise an exception if Job is Failed and Failed is not the expected condition.
if (
constants.JOB_CONDITION_FAILED not in conditions
constants.JOB_CONDITION_FAILED not in expected_conditions
and utils.has_condition(conditions, constants.JOB_CONDITION_FAILED)
):
raise RuntimeError(
Expand Down

0 comments on commit 09ba2d1

Please sign in to comment.