Merge pull request #79 from andreruffert/handleEnd-issue-fix

handleEnd issue fix
andreruffert · Aug 4, 2014 · e7a7c3d · e7a7c3d
2 parents 64a5dc9 + 3e87976
commit e7a7c3d
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 9 deletions.
diff --git a/dist/rangeslider.js b/dist/rangeslider.js
@@ -1,7 +1,7 @@
 /*! rangeslider.js - v0.3.1 | (c) 2014 @andreruffert | MIT license | https://github.com/andreruffert/rangeslider.js */
-'use strict';
-
 (function(factory) {
+    'use strict';
+
     if (typeof define === 'function' && define.amd) {
         // AMD. Register as an anonymous module.
         define(['jquery'], factory);
@@ -14,6 +14,7 @@
         factory(jQuery);
     }
 }(function($) {
+    'use strict';
 
     /**
      * Range feature detection
@@ -203,9 +204,8 @@
         this.$document.off(this.moveEvent, this.handleMove);
         this.$document.off(this.endEvent, this.handleEnd);
 
-        var posX = this.getRelativePosition(this.$range[0], e);
         if (this.onSlideEnd && typeof this.onSlideEnd === 'function') {
-            this.onSlideEnd(posX - this.grabX, this.value);
+            this.onSlideEnd(this.position, this.value);
         }
     };
 

diff --git a/dist/rangeslider.min.js b/dist/rangeslider.min.js
diff --git a/example/index.html b/example/index.html
@@ -169,10 +169,16 @@ <h2>Destroy a plugin instance</h2>
             onInit: function() {},
 
             // Callback function
-            onSlide: function(position, value) {},
+            onSlide: function(position, value) {
+                console.log('onSlide');
+                console.log('position: ' + position, 'value: ' + value);
+            },
 
             // Callback function
-            onSlideEnd: function(position) {}
+            onSlideEnd: function(position, value) {
+                console.log('onSlideEnd');
+                console.log('position: ' + position, 'value: ' + value);
+            }
         });
 
     });

diff --git a/src/rangeslider.js b/src/rangeslider.js
@@ -1,4 +1,6 @@
 (function(factory) {
+    'use strict';
+
     if (typeof define === 'function' && define.amd) {
         // AMD. Register as an anonymous module.
         define(['jquery'], factory);
@@ -201,9 +203,8 @@
         this.$document.off(this.moveEvent, this.handleMove);
         this.$document.off(this.endEvent, this.handleEnd);
 
-        var posX = this.getRelativePosition(this.$range[0], e);
         if (this.onSlideEnd && typeof this.onSlideEnd === 'function') {
-            this.onSlideEnd(posX - this.grabX, this.value);
+            this.onSlideEnd(this.position, this.value);
         }
     };