Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First issue #413

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

First issue #413

wants to merge 3 commits into from

Conversation

saisri0102
Copy link

Added FAISS index

VictorOdede
VictorOdede requested changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@VictorOdede VictorOdede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the contribution! We already have a decent faiss class implementation from a previous PR. You can look into it and add any missing parts: #396

@saisri0102
Copy link
Author

I don't see the changes done for #396 on main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorOdede VictorOdede VictorOdede requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saisri0102 @VictorOdede