Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data alignment checks for RX and TX #439

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tfcollins
Copy link
Collaborator

@tfcollins tfcollins commented May 18, 2023

Description

PR adds data alignment checks if buffers on RX and TX side to not meet the byte alignment within the IIO buffers. These will generate just warnings and not error.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • ADRV9361 + Example
  • ADRV9371 + Example

Test Configuration:

  • Hardware: ADRV9361, ADRV9371
  • OS: Ubuntu 22.04

Documentation

If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have signed off all commits and they contain "Signed-off by: "
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tfcollins tfcollins requested a review from mhennerich May 18, 2023 22:33
@github-actions
Copy link

github-actions bot commented May 18, 2023

Unit Test Results

1 177 tests  ±0   199 ✔️ ±0   4m 42s ⏱️ +8s
       1 suites ±0   978 💤 ±0 
       1 files   ±0       0 ±0 

Results for commit 95f92c8. ± Comparison against base commit a5132a2.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

Generated documentation for this PR is available at Link

@tfcollins tfcollins changed the base branch from master to main November 14, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant