fix(PeriphDrivers): Correct HART UART Driver Transmit Bugs #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interrupts could occur while manually loading the FIFO resulting in bogus data being transmitted in some cases.
Use of APB clock instead of ERFO prevents case of interrupts not working when system/peripheral clock is slower than UART clock.
github-actions
bot
added
MAX32675
sihyung-maxim
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use APB clock for HART UART to avoid case where UART clock is faster than system/periph clock to ensure UART interrupt actually vector.
Prevent bogus byte transmission due to interrupt occurring during manual FIFO load.
Minor corrections from previous PR code review.