Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC PATCH] iio: repeat channel support and dummy client example #39

Closed
wants to merge 9 commits into from
Closed

[RFC PATCH] iio: repeat channel support and dummy client example #39

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1911bf6
docs: clarify purpose of return value in callback
lucasrangit Aug 31, 2016
d66ff3f
iio: support repeated channels
lucasrangit Aug 29, 2016
81f5dc7
examples: dummy: create example tool that uses iio-dummy and iio-trig…
lucasrangit Sep 9, 2016
cc5b26f
example: dummy: document setup
lucasrangit Sep 12, 2016
ef5da2c
examples: dummy: add dependency and remove unused define
lucasrangit Sep 12, 2016
d32fe57
examples: dummy: make device, trigger, and buffer length into command…
lucasrangit Sep 12, 2016
55f963b
examples: dummy: add option to select read method
lucasrangit Sep 12, 2016
2ac05cc
examples: dummy: change buffer length option and add loop count option
lucasrangit Sep 12, 2016
a987367
test: iio_info: include repeat X if defined
lucasrangit Sep 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion tests/iio_info.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,15 @@ int main(int argc, char **argv)
if (format->is_fully_defined)
sign += 'A' - 'a';

printf(", index: %lu, format: %ce:%c%u/%u>>%u)\n",
if (format->repeat)
printf(", index: %lu, format: %ce:%c%u/%uX%u>>%u)\n",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this should this be format->repeat > 1 so we get consistent output if there is no repeat.

Copy link
Contributor Author

@lucasrangit lucasrangit Sep 14, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I will also make the snprintf usage consistent with how channel.c::get_scan_element() is done or whatever the best style is.

iio_channel_get_index(ch),
format->is_be ? 'b' : 'l',
sign, format->bits,
format->length, format->repeat,
format->shift);
else
printf(", index: %lu, format: %ce:%c%u/%u>>%u)\n",
iio_channel_get_index(ch),
format->is_be ? 'b' : 'l',
sign, format->bits,
Expand Down