Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include libzstd.dll in windows artifacts #1180

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Include libzstd.dll in windows artifacts #1180

merged 2 commits into from
Jun 27, 2024

Conversation

cristina-suteu
Copy link
Collaborator

PR Description

Add libzstd.dll to windows installer and windows packaged zips.
Fixes issue #1153

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have commented new code, particulary complex or unclear areas
  • I have checked that I did not intoduced new warnings or errors (CI output)
  • I have checked that components that use libiio did not get broken
  • I have updated the documentation accordingly (GitHub Pages, READMEs, etc)

@cristina-suteu cristina-suteu merged commit fea2a83 into main Jun 27, 2024
23 of 24 checks passed
@cristina-suteu cristina-suteu deleted the libzstd-iss branch June 27, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfcollins tfcollins tfcollins approved these changes

@dNechita dNechita dNechita approved these changes

@mhennerich mhennerich Awaiting requested review from mhennerich mhennerich is a code owner

@SRaus SRaus Awaiting requested review from SRaus SRaus is a code owner

@AAndrisa AAndrisa Awaiting requested review from AAndrisa AAndrisa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cristina-suteu @tfcollins @dNechita