Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure the sizeof argument to calloc is the second argument. #485

Merged
merged 1 commit into from
Mar 14, 2024
Merged

make sure the sizeof argument to calloc is the second argument. #485

merged 1 commit into from
Mar 14, 2024

Conversation

tsailer
Copy link
Contributor

@tsailer tsailer commented Mar 6, 2024

This PR makes sure that the sizeof argument to calloc is the second argument. New versions of gcc want to enforce this.

nunojsa
nunojsa reviewed Mar 6, 2024
View reviewed changes
Copy link
Contributor

@nunojsa nunojsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Thomas,

Thanks for contributing... Can you please sign off your commit and re-push? You can just do git commit --amend -s. Note you need an email and user in your gitconfig.

Other than the above, LGTM

@tsailer
make sure the sizeof argument to calloc is the second argument.
bbdfd4d 
new versions of gcc want to enforce this

Signed-off-by: Thomas Sailer <[email protected]>
@cristina-suteu cristina-suteu merged commit 565cade into analogdevicesinc:main Mar 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dNechita dNechita dNechita approved these changes

@nunojsa nunojsa nunojsa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tsailer @dNechita @nunojsa @cristina-suteu