Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osc.c: Allow setting the capture timeout via .ini file #484

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

dNechita
Copy link
Contributor

@dNechita dNechita commented Mar 5, 2024

There are scenarios where a larger timeout is needed. For example, when using the UART interface, the bandwith is significantly lower than USB or Ethernet. When "capture_timeout" is read from a .ini file, the assigned value (e.g. "capture_timeout=5000") will overwrite the value that osc computes internally.

@dNechita
Copy link
Contributor Author

dNechita commented Mar 5, 2024

To add more details:
The logic used by osc to compute the timeout was like this:

  • calculate how much time the hardware device would need to capture the samples. This is done by considering the sampling rate of the hardware and how many samples are set to be captured.
  • add 1000 milliseconds to the time calculated above. This is to cover the time it would take the acquisition data to travel from the hardware over USB or Network.

But on some setups, where UART is being used and there is a larger number of samples to be transferred, the 1000 milliseconds don't even begin to cover the time needed for the samples to be sent over UART.

There are scenarios where a larger timeout is needed. For example, when using the UART interface, the bandwith is significantly lower than USB or Ethernet.
When "capture_timeout" is read from a .ini file, the assigned value (e.g. "capture_timeout=5000") will overwrite the value that osc computes internally.

Signed-off-by: Dan <[email protected]>
@cristina-suteu cristina-suteu merged commit 8fa73f9 into main Mar 13, 2024
10 checks passed
@cristina-suteu cristina-suteu deleted the expose-timeout-in-ini-file branch March 13, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants