Replace deprecated GTK functions #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristina-suteu
requested review from
dNechita and
a team
and removed request for
a team
nunojsa
reviewed
Jan 29, 2024
There was a problem hiding this comment.
Some minor nits...
I'm also not sure how things are handled in osc with respect to backporting fixes to the release branches (2022_R2 in this case). If that is something that should be done, I would recommend to reorder your series so that the fixes are the first patches (and hence easier to backport)
use gdk_cursor_new_for_display instead of gdk_cursor_new Signed-off-by: Cristina Suteu <[email protected]>
replace gdk_screen_get_width/height with monitor geometry Signed-off-by: Cristina Suteu <[email protected]>
cristina-suteu
force-pushed
the
fix-deprecated
branch
from
51f0e81
to
08f895d
Compare
use gtk_container_add instead of gtk_widget_reparent get widget current parent, hide widget ref widget before removing from current container, gtk_container_remove automatically unrefs widget remove widget from current container and add to the new one Signed-off-by: Cristina Suteu <[email protected]>
use gtk_widget_set_halign/valign instead of gtk_misc_set_alignment Signed-off-by: Cristina Suteu <[email protected]>
cristina-suteu
force-pushed
the
fix-deprecated
branch
from
08f895d
to
def1b17
Compare
dNechita
reviewed
Jan 31, 2024
use gtk_widget_get_preffered_size instead of gtk_widget_size_request use gtk_widget_set_halign/valign instead of gtk_misc_set_alignment use gtk_widget_set_margin_start/end/top/bottom instead of gtk_misc_set_padding use gtk_container_add instead of gtk_widget_reparent get current parent for widget and hide the widget add ref for the widget before removing, gtk_container_remove automatically unrefs object when removing from container add widget to new container and show widget Signed-off-by: Cristina Suteu <[email protected]>
use CSS style provider to set box widget color instead of gtk_widget_override_color add box colors to style sheet Signed-off-by: Cristina Suteu <[email protected]>
use gtk_tool_button_set_icon_name instead of gtk_tool_button_set_stock_id Signed-off-by: Cristina Suteu <[email protected]>
cristina-suteu
force-pushed
the
fix-deprecated
branch
from
def1b17
to
c8e444d
Compare
dNechita
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced most deprecated gtk3 functions
The threading methods gdk_threads_init, gdk_threads_enter, gdk_threads_leave will be addressed in a separate PR. These require a greater change within the application code.